Code Monkey home page Code Monkey logo

Comments (10)

dnephin avatar dnephin commented on May 24, 2024 1

We may need to move some of the fakeClient into cli/internal/test/ and export the struct and fields. There are some packages (stack, and service at least) that use parts of other clients.

from cli.

jeremcs avatar jeremcs commented on May 24, 2024

Some items on the list seem to be deprecated as they do not appear when setting the DOCKER_HIDE_LEGACY_COMMANDS variable:

  • bundlefile
  • inspect
  • prune
  • registry
  • task

Should we remove them from the list ?

(cc @kelu27)

from cli.

vdemeester avatar vdemeester commented on May 24, 2024

@jeremcs I would say not (because some of them won't ever be removed).

from cli.

clook avatar clook commented on May 24, 2024

Starting working on service (#201)

from cli.

adshmh avatar adshmh commented on May 24, 2024

#dibs on task package

from cli.

adshmh avatar adshmh commented on May 24, 2024

#dibs on checkpoint package.

from cli.

Zebrilee avatar Zebrilee commented on May 24, 2024

hi @vdemeester ,
I was working on prune test in the last hackergarten but I saw the commit two days ago which modify the prune.go file and add a prune_test.go too.
I believe this part is ok or is there something else to do?

from cli.

vdemeester avatar vdemeester commented on May 24, 2024

@Zebrilee oh right yeah, I should mark it on the issue

from cli.

redpanda avatar redpanda commented on May 24, 2024

#dibs on network package.

from cli.

vdemeester avatar vdemeester commented on May 24, 2024

Closing this as all those packages have some test. We can enhance the coverage but I feel this issue can be considered as done.

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.