Code Monkey home page Code Monkey logo

Comments (5)

aaronlehmann avatar aaronlehmann commented on May 23, 2024 1

I don't think Error response from daemon is so bad, but the messages get very messy when the error returned by the daemon has a lot of unnecessary prefixes.

For example, trying to run a binary that doesn't exist:

docker: Error response from daemon: oci runtime error: container_linux.go:262: starting container process caused "exec: \"mozilla\": executable file not found in $PATH".

There are so many :s in that message, and most of it isn't useful. The source file and line number is the most egregious part - that's absolutely no help to the user and makes it look like something is wrong internally. And we have a quoted string with backslash-escaped characters for no good reason.

I think it should read:

docker: Error response from daemon: executable file "mozilla" not found in $PATH

from cli.

thaJeztah avatar thaJeztah commented on May 23, 2024

/cc @friism @dnephin @vdemeester

from cli.

dnephin avatar dnephin commented on May 23, 2024

I think there is value in understanding where the error is coming from. "from daemon" is probably not the right term, so we should change that part to something more meaningful. "from server", "from api" ?

from cli.

thaJeztah avatar thaJeztah commented on May 23, 2024

Idk, perhaps we should look at errors individually, but from a UX perspective, there's many examples where it doesn't really matter I guess. Sometimes errors are wrapped three times (error response from daemon: error while doing something: something was not found).

Perhaps logging such errors would be useful, but printing a more user-friendly message.

from cli.

sam-thibault avatar sam-thibault commented on May 23, 2024

This is an old issue. I will close it as stale.

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.