Code Monkey home page Code Monkey logo

Comments (4)

ElektroKill avatar ElektroKill commented on August 26, 2024

Hi, sorry for the rather late response. I had another look at your issue and I cannot reproduce point 2 with the latest release of dnSpyEx. Could you confirm that it also works for you? As for the reason why point 2 might no longer be an issue, it might be that the update to Roslyn 4.x has fixed this compiler issue.

As for point 1, I have pushed a fix for the invalid parameter names being generated. This was a bug that prevented the decompiler from removing the unnecessary parameter declarations. A build with the fix available can be found here https://github.com/dnSpyEx/dnSpy/actions/runs/2585026699 (at the time of writing this it is still building).

Could you please verify that both of the issues you outlined in the initial post are no longer present?

from dnspy.

PercyDan54 avatar PercyDan54 commented on August 26, 2024

I downloaded the build you linked and point 1 still exists
image
Point 2 is resolved

from dnspy.

ElektroKill avatar ElektroKill commented on August 26, 2024

Hello, it seems my initial fix only fixed the problem for cases without nested delegate construction. Can you please try the build from https://github.com/dnSpyEx/dnSpy/actions/runs/2589578710 where I hopefully managed to fix this issue for nested delegate construction?

from dnspy.

PercyDan54 avatar PercyDan54 commented on August 26, 2024

Hello, it seems my initial fix only fixed the problem for cases without nested delegate construction. Can you please try the build from https://github.com/dnSpyEx/dnSpy/actions/runs/2589578710 where I hopefully managed to fix this issue for nested delegate construction?

Can confirm it resolves the problem, thanks!

from dnspy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.