Comments (7)
That sounds good to me.
I think polygon should be supported tho, that seems like a bug.
from flutter_svg.
I guess <title>
might just be a no-op, like <desc>
appears to be?
from flutter_svg.
I think the polygon issue is when it is in a <defs>
section:
<defs>
<polygon id="path-1" points="0 14 7.46666667 14 7.46666667 0 0 0"></polygon>
</defs>
This gets referred to later:
<mask id="mask-2" fill="white">
<use xlink:href="#path-1"></use>
</mask>
from flutter_svg.
I've had some thoughts o ftrying to use <title>
(but desc doesn't seem as useful) for a11y stuff, but nothing too concrete.
There's also been at least some discussion around supporting shapes in <defs>
, but nothing concrete there yet either.
I would want to avoid adding too much overhead just to limit verbosity, but if all we're talking about is a simple hashset of elements I think that's probably ok. Of course, it'd be possible to preprocess SVGs to remove these kinds of elements too with XSLT or somesuch, which would add no overhead to the parser for it.
from flutter_svg.
I guess an "avoid verbose repeated output" switch could be on only in debug mode — a bit like the error reporting in flutter core that abbreviates repeated errors.
from flutter_svg.
I've checked in a fix for this in 000e17f - wrapped in an assert, so no impact on release code.
It will now track whether it's printed about a particular unhandled element and only print on the first time.
from flutter_svg.
awesome — I didn't think to use assert
in this way. Thanks!
from flutter_svg.
Related Issues (20)
- Grid problems in gradients HOT 1
- How to achieve difference blend mode layer like Figma HOT 1
- Svg not rendered properly some parts are not visible even without impeller HOT 1
- Crashing with zero length line in Flutter 3.22.1 HOT 1
- Migration from the `AssetBundlePictureKey` apis
- [PERFORMANCE] ColorFilter introduces jank HOT 1
- SVG not showing at all HOT 2
- image cannot be displayed HOT 2
- [BUG] Caching is not working correctly.
- Invalid double
- Flutter web WASM no longer allows FFI imports
- some 'style' attribute will cause the svg file to fail to render.
- crash on iOS when svg in list HOT 5
- colorFilter not working in Flutter Web Apps on mobile devices with iOS 17.2 on Safari anymore HOT 3
- Correct error handling in custom ByteLoader
- Would it improve performance if `ByteLoaders` could reuse a pool of Isolates instead of creating a new one every time with `compute`? HOT 3
- SVG image is not displayed when styles and classes are used - drawing issue still in ^2.0.10+1 HOT 4
- SVG showing Black bacground when rendered HOT 1
- Issue with Wasm Compilation: dart:ffi Not Supported HOT 4
- Error found in FirebaseCrashlytics
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter_svg.