Code Monkey home page Code Monkey logo

Comments (9)

jd-carroll avatar jd-carroll commented on May 22, 2024

Stacktrace:

ReduceStream (ReduceStream.js:9)
initialize (SequentialLayout.js:45)
Controller (Controller.js:71)
View (View.js:83)
(anonymous function) (Controller.js:145)
child (Controller.js:146)
initialize (Dots.js:24)
Controller (Controller.js:71)
View (View.js:83)
(anonymous function) (Controller.js:145)
child (Controller.js:146)
createDots (Carousel.js:88)
initialize (Carousel.js:19)
Controller (Controller.js:71)
View (View.js:83)
(anonymous function) (Controller.js:145)
child (Controller.js:146)
(anonymous function) (main.js:9)
execCb (require.js:1693)
...

from samsara.

joeandrews avatar joeandrews commented on May 22, 2024

Last working commit is cd013d8a38fdb7db187a2bda6d71b983bf9bfe1f

from samsara.

jd-carroll avatar jd-carroll commented on May 22, 2024

Looks like the commit# e5f18ea broke it with this line

from samsara.

jd-carroll avatar jd-carroll commented on May 22, 2024

The object needs to be a stream object, and I am new here so I don't know what the original issue was which required this change.

from samsara.

jd-carroll avatar jd-carroll commented on May 22, 2024

So in commit# e5f18ea there are 2 separate changes. One is to ui/Slider.js and the other is to layouts/SequentialLayout.js. The change to SequentialLayout.js is not related to the commit message.

from samsara.

jd-carroll avatar jd-carroll commented on May 22, 2024

Reverting the change at e5f18ea to layouts/SequentialLayout.js fixes the issue...

But should understand why that change was included in the first place.

from samsara.

dmvaldman avatar dmvaldman commented on May 22, 2024

Thanks for pointing this out! Sorry it took me a few days to respond. I'll be looking into this soon. Should be a simple fix.

from samsara.

dmvaldman avatar dmvaldman commented on May 22, 2024

This should be resolved in b09b6bf, would appreciate if you could verify.

from samsara.

dmvaldman avatar dmvaldman commented on May 22, 2024

Closing as this has been fixed.

from samsara.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.