Consider giving Cython example about dlpack HOT 4 CLOSED

Randomly saw it: TBH, think the PyErr_Fetch is just nonsense to begin with this is just a tp_dealloc effectively, and tp_dealloc doesn't need this.

There is a fun twist here also where the code knows it cannot raise an error, but still decides it should restore an existing one :).

from dlpack.

Randomly saw it: TBH, think the PyErr_Fetch is just nonsense to begin with this is just a tp_dealloc effectively, and tp_dealloc doesn't need this.

Looking at the PyCapsule code, I agree that this doesn't seem necessary.

from dlpack.

Note that this issue is originally about giving a Cython example, not just the PyErr_Fetch question.

from dlpack.

Yeah, even the remaining error check isn't really necessary but at least it makes some sense for good sport.

Sorry about the Closes tag, it may indeed still make sense to add Cython examples.

from dlpack.