Question: Connection reset by peer errors about docker-client HOT 5 CLOSED

Hi @rwmajor2,

No it won't solve such errors as it simply replaces autovalue with immutables not Guava entirely. However, this seems like a bug to me, does it happen consistently?

from docker-client.

@dmandalidis One more random question; sorry this is not on topic of this issue. Should I always be diligent to docker.close() any docker connections I create? Seems like I have a memory leak in my application but I noticed I don't .close() any of my connections that I create.

from docker-client.

@rwmajor2 as a general rule of thumb you should always close the connections you open and if you don't, you have the ideal memory leak candidate :) However, constructing a new DockerClient each time is very expensive since two javax.ws.rs.client.Client are created along. The Jersey implementation guarantees thread safety but I will need to check if the DefaultDockerClient has the same guarantees which is actual the answer to your comment in #45.

from docker-client.

@dmandalidis Ok, thanks. I had tried to reuse a DockerClient instance for each thread but kept running into problems reusing it. But, perhaps I didn't know what I was doing exactly.

from docker-client.

Hi @rwmajor2

Spent some time investigating the thread safety issues you mentioned here and in #45. To my understanding, the DefaultDockerClient is thread-safe. I 'm closing this issue, and if I 'm wrong, please open a bug with a code-block reproducing the problem.

from docker-client.