Comments (6)
dlbeer
commented on September 13, 2024
Yes, you will need a compiler that supports C99 to build it. If you're building on Windows then you might want to consider MinGW. You will likely also need to modify the Makefile, and you won't be able to build the demo program (which is Linux-only).
from quirc.
kaworu
commented on September 13, 2024
@dlbeer any consideration for dropping VLA as their support is optional in C11?
from quirc.
dlbeer
commented on September 13, 2024
On Tue, Jun 06, 2017 at 12:01:02AM -0700, Alexandre Perrin wrote:
@dlbeer any consideration for dropping VLA as their support is
optional in C11?
I suppose an explicit alloca() wouldn't hurt. Would that help with VC++
though? I thought it didn't support designated initializers either, but
I might be wrong about that.
…--
Daniel Beer <[email protected]> http://dlbeer.co.nz/
PGP: BA6E 0B26 1F89 246C E3F3 C910 1E58 C43A 160A 553B
from quirc.
kaworu
commented on September 13, 2024
No idea about VC++ to be honest, I'm kind of hijacking this issue because I feel uneasy with VLA as they are seldom used in other projects and also are optional in C11.
alloca(3) isn't a big improvement as failure cannot be easily checked (e.g. the GNU man page say that on failure it can UB). I feel like a library should be as robust as possible, and neither VLA nor alloca(3) fit the bill. Allocating on the heap (i.e. malloc(3)) should be safer as we don't have any control on how deep the stack is, its limit, and q->w and will come with the usual cost of having to free the memory explicitely.
As for VC++, the situation may improve. While Microsoft has ignored C for long, they've ported OpenSSH to Windows and provide a Linux compatibility now. I think it has/will require them to support some C99 features (and maybe C11), so let's wait and see.
from quirc.
dlbeer
commented on September 13, 2024
On Tue, Jun 06, 2017 at 05:07:57AM -0700, Alexandre Perrin wrote:
No idea about VC++ to be honest, I'm kind of hijacking this issue because I feel uneasy with VLA as they are seldom used in other projects and also are optional in C11.
`alloca(3)` isn't a big improvement as failure cannot be easily checked (e.g. the GNU man page say that on failure it can UB). I feel like a library should be as robust as possible, and neither VLA nor `alloca(3)` fit the bill. Allocating on the heap (i.e. `malloc(3)`) should be safer as we don't have any control on how deep the stack is, its limit, and `q->w` and will come with the usual cost of having to free the memory explicitely.
As for VC++, the situation may improve. While Microsoft has ignored C for long, they've ported OpenSSH to Windows and provide a Linux compatibility now. I *think* it has/will require them to support some C99 features (and maybe C11), so let's wait and see.
Fair enough. Perhaps we could allocate a row_average buffer in the
structure at the same time we allocate memory for pixels?
…--
Daniel Beer <[email protected]> http://dlbeer.co.nz/
PGP: BA6E 0B26 1F89 246C E3F3 C910 1E58 C43A 160A 553B
from quirc.
kaworu
commented on September 13, 2024
Agreed it seems to be the way to go after a quick look. I'll happily work on a patch and PR.
from quirc.
Related Issues (20)
- Detecting QRs with rounded postion patterns HOT 2
- Stack corruption when grid_size > QUIRC_MAX_GRID_SIZE HOT 2
- Add support for micro QR-Code HOT 3
- Esp32 cam QR code decoding failed error
- Support GS1/AIM data encoding defined in ISO/IEC 18004:2015(E)
- fake capstones
- Do not support chinese word decode？
- perspective
- How to debug the robustness of decode？
- incomplete definition of type 'struct quirc'
- Stack overflow error on ESP32 HOT 2
- Why not support QR Code Model1?
- Can it decode code 128 barcode HOT 1
- Detecting nonexistent qr codes in single (complex) qr code HOT 1
- Not Issue, but question: best qr format to be decoded?
- Not work well in a pure qrcode without extra pixel
- If a single image contains multiple QR codes, how should the resulting parsed data be handled?
- Failed to resolve component 'quirc'.
- Error 4 in ESP32 CAM AI THINKER
- The sdl pkg-config is named wrong
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quirc.