Dealing with rebased branches about autoapproval HOT 5 CLOSED

Just noticed approval is only done when a pull request is opened or re-opened. So I guess it would also need to run on pull request updating.

from autoapproval.

Thanks for reporting the issue.

Can you please provide a better use case for the problem? I didn't really understand this sentence.

Because of this behaviour, rebasing a branch results in the branch not being approved anymore, while still having the label.

from autoapproval.

Sure!

So I use Dependabot and it creates a several pull requests at the same time. Autoapproval approves all those pull requests, and so whichever pull request finishes the build process first is merged automatically by Dependabot.

However, after merging that first pull request, all other pull requests are updated with master through rebasing, which removes all reviews from the pull requests.

Dependabot is then unable to merge, because there's no approval anymore and Autoapproval is not re-approving the updated pull request, so then I have to manually approve it.

from autoapproval.

Thanks for your explanation! 👍
This is a valid concern. But I doubt that would work because if PR contains the labels of the approved PR, it will not be approved one more time. Being assumed the following:

• if PR contains the labels of the approved PR it will be considered as already approved.

from autoapproval.

I know that if you update the branch from GitHub interface, it will not reset the review. Maybe you can consider that?
Another thing which could work for you is removing the label of the approved PR, so that it could be approved one more time.

from autoapproval.