Comments (10)
Hi,
Thanks a lot for reporting this!
Looks like a bug in the plugin which should be fixed. Yes, I think it's worth fixing because in theory the plugin should work in IntelliJ IDEs.
from limited-wip.
Nice, it seems also that the line change counter is also wrong.
I don't have knowledge about developing plugins, but if I have some time I'll try to take a look. I've started to make C# live coding on twitch, and I want to use TCR, and this plugin will help me a lot!
Maybe I tried to make a live to learn and try to fix this bug, is an idea that occurs me now.
from limited-wip.
@dkandalov can you give me some steps about how can I run this project to debug? I tried to import on IntelliJ but was not able to configure to run and debug :/
from limited-wip.
Just have discovered the intellij->runIde
task, now I'll try to discover how to run on Rider
from limited-wip.
Just to update, I was able to debug on Rider! I'll probably start to check this issue tomorrow, in a live code session on Twitch. But my live code is in Portuguese.
Hope I'll be able to identify and help with this issue
from limited-wip.
Hi @dkandalov , today I spent some time debugging the issue and I found a different behavior between IntelliJ and Rider.
IntellJ send a Notification when the Test Runner finishes with something like this 10:52 PM Tests passed: 1
. But Rider doesn't send this Notification.
Making some research on the internet I found that is an abstract TestStatusListener that could be used to implment this.
But probably will need to make a lot of changes into this plugin.
I didn't tried to use this approach, I'll like to get your opinion related to this before try to use this Listener.
from limited-wip.
Oh, this explains why TCR doesn't work.
If TestStatusListener
works and has all the information, it's good enough (I vaguely remember not using it for some reason, but if it works now this is great).
from limited-wip.
I need to check if it works, I don't know if it has all the information. The documentation of this is not so good as I was expecting.
I'll make some tests, and update this issue ASAP.
from limited-wip.
Yes, there is not much documentation but given that TestStatusListener
is not part of "openapi" this is fair enough I guess. I usually check out IJ source code and browse it as documentation of how things are actually used.
I quickly looked at TestStatusListener
and there are couple potential problems:
notifySuiteFinished(AbstractTestProxy root)
is not passing the current project, so you essentially don't know the project in which it was called. This function is deprecated by maybe it's still called from some unit testing plugin 🤷♂️- in
notifySuiteFinished(@Nullable AbstractTestProxy root, Project project)
theroot
is nullable so there is not guarantee that there will be an object describing test results
In practice, all of the above might work just fine for majority of languages and testing frameworks. But the only way to really know is to manually test I guess.
from limited-wip.
Actually, I suspect that Rider doesn't use TestStatusListener
at all. There is a chance it's C# code from resharper running in a separate process and using IJ api for UI.
from limited-wip.
Related Issues (20)
- Commit without dialog action doesn't work in 2019.3 EAP HOT 2
- Feature Request: support timeout period less than 1 minute HOT 5
- not committing on test run HOT 5
- Commits on Compound test when one fails
- should not update shared misc.xml HOT 2
- TCR: support mode to commit/revert on expected red
- TCR: killing tests during long execution is considered a failure and reverts all changes
- Commits are still allowed even if you go over watchdog threshold
- Commit fails if reformat / optimise imports is enabled HOT 1
- TCR without revert
- Option to force entry of the commit message HOT 2
- Two commit dialogs open when tests run with Gradle run configuration
- AlreadyDisposedException: Cannot create com.intellij.openapi.vcs.ProjectLevelVcsManager
- Manual undo operation does not work properly after failing test
- feature idea: option to use test name for commit message in TCR mode HOT 1
- should the TCR mode automatically commit after I run a test? It doesn't seem to be committing. HOT 2
- Feature request: TCR option to prompt for commit message HOT 1
- Press "ok" before auto-reverting HOT 2
- Slow operations are prohibited on EDT
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from limited-wip.