Code Monkey home page Code Monkey logo

Comments (7)

justvanrossum avatar justvanrossum commented on August 24, 2024 1

Additionally, I think the warn comes from the fact that "horncmb" does have a _horn anchor in the source, but there isn't a single glyph with a horn anchor to attach it to. That possibly causes fontmake to not mark it as class 3.

So, ok to close this issue? The "meta" table problem has been resolved with #118.

from bungee.

vv-monsalve avatar vv-monsalve commented on August 24, 2024
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
> > The OpenType 'meta' table originated at Apple. Microsoft added it to OT with > just two DataMap records: > > - dlng: comma-separated ScriptLangTags that indicate which scripts, > or languages and scripts, with possible variants, the font is designed for. > > - slng: comma-separated ScriptLangTags that indicate which scripts, > or languages and scripts, with possible variants, the font supports. > > > The slng structure is intended to describe which languages and scripts the > font overall supports. For example, a Traditional Chinese font that also > contains Latin characters, can indicate Hant,Latn, showing that it supports > Hant, the Traditional Chinese variant of the Hani script, and it also > supports the Latn script. > > The dlng structure is far more interesting. A font may contain various glyphs, > but only a particular subset of the glyphs may be truly "leading" in the design, > while other glyphs may have been included for technical reasons. Such a > Traditional Chinese font could only list Hant there, showing that it’s designed > for Traditional Chinese, but the font would omit Latn, because the developers > don’t think the font is really recommended for purely Latin-script use. > > The tags used in the structures can comprise just script, or also language > and script. For example, if a font has Bulgarian Cyrillic alternates in the > locl feature for the cyrl BGR OT languagesystem, it could also indicate in > dlng explicitly that it supports bul-Cyrl. (Note that the scripts and languages > in meta use the ISO language and script codes, not the OpenType ones). > > This check ensures that the font has the meta table containing the > slng and dlng structures. > > All families in the Google Fonts collection should contain the 'meta' table. > Windows 10 already uses it when deciding on which fonts to fall back to. > The Google Fonts API and also other environments could use the data for > smarter filtering. Most importantly, those entries should be added > to the Noto fonts. > > In the font making process, some environments store this data in external > files already. But the meta table provides a convenient way to store this > inside the font file, so some tools may add the data, and unrelated tools > may read this data. This makes the solution much more portable and universal. >

Original proposal: fonttools/fontbakery#3349

  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]

from bungee.

justvanrossum avatar justvanrossum commented on August 24, 2024

Ouch, I did add the public.openTypeMeta info to the sources, but they were ignored in the assemble phase. Fixing.

from bungee.

justvanrossum avatar justvanrossum commented on August 24, 2024

Do you have an idea how to fix the horncmb / GDEF warning?

from bungee.

vv-monsalve avatar vv-monsalve commented on August 24, 2024

Do you have an idea how to fix the horncmb / GDEF warning?

The comb marks need to have anchors to be listed as class 3 in GDEF by Fontmake. However, after inspecting the file, I've seen the composite glyphs are decomposed, so I think we could leave it like that and wait for users' feedback if they need another accented letter using it. In that case, it would probably be needed to create the composite ':D

from bungee.

vv-monsalve avatar vv-monsalve commented on August 24, 2024

So if there is no base glyph using it, I wonder if FM is not even including the anchor in the glyph. Reviewing this again, yes, the source have the anchor, but inspecting the font the anchor is not in there, and FB checks only the binaries.

So yes, I think we can close this issue.

from bungee.

justvanrossum avatar justvanrossum commented on August 24, 2024

FB probably decides on the “cmb” aspect that it should be class 3, regardless of anchors.

from bungee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.