Logic error in `below()` etc. after updating `order_with_respect_to` fields about django-ordered-model HOT 7 CLOSED

Resolved by #248

from django-ordered-model.

This appears to also be the case with the above() method.

from django-ordered-model.

I actually also just ran into this - I think that you are right.

from django-ordered-model.

Actually, i think that 'return' may not be right regardless.

If '>' work needs to be done
If '<' work may need to be done. (i.e. just becuase it's already below doesn't mean it's in the right place below).
if '==' work needs to be done

This is just from a quick read-over though.

from django-ordered-model.

Also it looks like the 'to()' function has some issues in some cases. I'll put together a pull request.

from django-ordered-model.

Please see #93 for a proposed solution to this and a related issue that I was having in the case where an ordered item is dragged from one list to another.

In this case, I am first updating the order_with_respect_to fields and then calling "above()" -- but this does not work in the trunk because the 'order' value of the dragged item is identical to the 'order' of an item in the existing list.

from django-ordered-model.

My take on this is that we need to fix .save() when changing fields contained in order_with_respect_to to maintain the predicate that the items are in order within the old and new groups. Attempting repair work in .to(), .above(), .below() methods is not a good solution. So really this ticket is the same issue as #121 and #85. I've hit this myself so how to sort it out for the first 2.0 release.

from django-ordered-model.