commitWithin gives serializing error about pysolr HOT 6 CLOSED

Bizarre. No clue what's going wrong here, since etree has no problems serializing integers. Using pdb to inspect the message (pysolr.py, line 686 from the traceback) would probably be informative.

from pysolr.

pdb under mod_wsgi in production isn't really an option I'm afraid, and I haven't been able to reproduce this in a test environment.

from pysolr.

Then perhaps setting up a try/except block that catches the error & logs what was sent? You might also try installing lxml, as it looks like you're falling back on Python's etree, which sometimes has subtle differences from lxml.etree.

from pysolr.

We just hit this. Can pysolr not simply do the type conversion of the commitWithin arg from int -> str?

Happy to contribute a PR if so desired.

from pysolr.

This is an annoying limitation in etree:

>>> from xml.etree.ElementTree import Element, ElementTree
>>> import sys
>>> ElementTree(Element(42)).write(sys.stdout)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 812, in write
    self._root, encoding, default_namespace
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 881, in _namespaces
    _raise_serialization_error(tag)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1047, in _raise_serialization_error
    "cannot serialize %r (type %s)" % (text, type(text).__name__)
TypeError: cannot serialize 42 (type int)

Since ElementTree is [arguably] braindead I'd vote for a pull request adding an str() call on pysolr.py#L689 and, ideally, a test exercising this path.

from pysolr.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from pysolr.