Code Monkey home page Code Monkey logo

Comments (6)

bochecha avatar bochecha commented on August 19, 2024

Here are the patches:
http://bochecha.fedorapeople.org/pysolr/0001-Removed-trailing-white-spaces.patch
http://bochecha.fedorapeople.org/pysolr/0002-Properly-handle-errors-from-a-Solr-instance-deployed.patch

First one is just a dumb patch removing all trailing white spaces. I had
done it in my local clone of pysolr, so I tought I'd submit it anyway, but
split from the main patch.

The second one is what actually matters for this issue. I tested it with
Solr deployed in a Tomcat 6 server on Windows. Further testing with
different versions of Tomcat or Tomcat on other OSes would be greatly
appreciated. :)

As mentioned in the commit message, Tomcat doesn't generate valid XML as
its output, so I needed to introduce the BeautifulSoup dependency.

If the server is identified neither as Tomcat nor as Jetty, then the same fallback as before is used: display the full html message.

from pysolr.

bochecha avatar bochecha commented on August 19, 2024

Is anybody here? Any comment on the patch?

from pysolr.

toastdriven avatar toastdriven commented on August 19, 2024

Sorry, never got an e-mail notification about this. Will try to apply sometime later this week.

from pysolr.

toastdriven avatar toastdriven commented on August 19, 2024

Both of those patches 403 on me.

from pysolr.

bochecha avatar bochecha commented on August 19, 2024

Right, sorry about that.

This should be fixed now.

from pysolr.

toastdriven avatar toastdriven commented on August 19, 2024

Haha. Patch 0001... REJECTED! Sorry, I like having the indentation level match the scope it's in.

Patch 0002 had to be applied by hand, but seem to work in my testing. Thank you very much! Fixed in SHA: a8b7d08

from pysolr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.