STDIN not being sent to filter processes about django-compressor HOT 5 CLOSED

Using <script type="text/coffeescript" src="{{ STATIC_URL }}tests.coffee" charset="utf-8"></script> (with STATIC_URL) causes an error too...

    Caught UncompressableFileError while rendering: 'tests.coffee' isn't accesible via COMPRESS_URL ('/static/') and can't be compressed

from django-compressor.

I've located where the problem is occurring.

The else clause never executes to send the stdin to the process. In my coffeescript example configuration, (using stdin/stdout), the variables get set as so:

infile: None
self.filename: /snip/project/apps/tiny/static/tests.coffee

The command needs stdin, but doesn't get it, because of the or self.filename is not None check.

When it gets around to the YUI filter, both are none, so it sends the stdin that time and gets real output.
I fixed it by removing the self.filename check:

if infile is not None:

Here's the troubled line causing the issue.
https://github.com/jezdez/django_compressor/blob/master/compressor/filters/base.py#L68

Would love a quick fix. Thanks!

from django-compressor.

Pull request to fix this opened:
#53

from django-compressor.

This needs tests.

from django-compressor.

Alright. The problem with testing for infile not being None was that sometimes it stayed None.

Here, you see infile will still be None if the else executes (and it does in some cases). Which will render if infile is not None (on line 68) problematic.
https://github.com/jezdez/django_compressor/blob/master/compressor/filters/base.py#L60

And as for self.filename, I tested that out, and that check isn't even needed. For that reason, my fix wasn't complete, but I've completely fixed it and tested it out, and seeing where the execution is going on each test, so it's all correct now. :)

A test for this is coming.

Update: A test for this is now committed, as well as the correct fix.

from django-compressor.