[BUG] Cms check show wrong error about django-cms HOT 3 CLOSED

@MrUsiPusi Thank you! Well spotted! django CMS checks both the "old" MIDDLEWARE_CLASSES and the "new" MIDDLEWARE. Since MIDDLEWARE_CLASSES was removed in Django 2 (I think), django CMS will only need to check for MIDDLEWARE and adjust its error messaeg accordingly.

from django-cms.

@raffaellasuardini I think the issue here is that the error message says MIDDLEWARE_CLASSES regardless of if the setting is MIDDLEWARE_CLASSES or MIDDLEWARE. So I think the fix would likely be;

 if getattr(settings, 'MIDDLEWARE', None): 
     middlewares = settings.MIDDLEWARE
     setting_name = "MIDDLEWARE"
 else: 
     middlewares = settings.MIDDLEWARE_CLASSES
     setting_name = "MIDDLEWARE_CLASSES"
 for middleware in required_middlewares: 
     if middleware not in middlewares: 
         section.error("%s middleware must be in %s" % (middleware, setting_name)) 

from django-cms.

We can imho also remove the check for MIDDLEWARE_CLASSES since it's been removed from Django since v2.0

from django-cms.