Generated code from an XML file that only contains properties does not compile with crossroads about dbus-rs HOT 4 CLOSED

code = code.replace(
  ".annotate(\"org.freedesktop.DBus.Property.EmitsChangedSignal\", \"true\")",
  ".emits_changed_true()",

Well, if it's that simple, consider it done :-) Let me know if it works as expected now. Thanks!

from dbus-rs.

Hi!

.get(|_, t: &mut T| t.test_property())

I just pushed a commit that does just what it suggest. Can you try it and see if it resolves the problem for you?

An another thing that I also notice, is that the annotation for the EmitsChangedSignal is ignored and a call to .changed_msg_fn() is not generated. Is that expected?

I guess it is, given the comment I found in the code :-/

        if p.can_set() {
            // TODO: Handle EmitsChangedSignal correctly here.
            *s += &format!("\n            .set(|_, t, value| t.{}(value).map(|_| None))", p.set_fn_name);
        }

from dbus-rs.

I just pushed a commit that does just what it suggest. Can you try it and see if it resolves the problem for you?

It does. Thank you for the fix !

I guess it is, given the comment I found in the code :-/

For the moment as a workaround I am just doing in the build.rs something like

    code = code.replace(
        ".annotate(\"org.freedesktop.DBus.Property.EmitsChangedSignal\", \"true\")",
        ".emits_changed_true()",
    );

Probably it could be also a way of implementing in the future. Detect if the value of the annotation is org.freedesktop.DBus.Property.EmitsChangedSignal and depending on the value replace it with the correct calling function ...

from dbus-rs.

It works as expected! Thank you !

from dbus-rs.