Comments (4)
liked this approach, will follow it now onwards! 👌🏻
thanks for writing 🙌🏻
from blog.
Gem of a post man, wish could have found it sooner!
However, in hindsight of working with big features we oftentimes have to update our PRs with requested changes, which can be needed on its subsequent PRs as well. Does this mean we'd have to rebase subsequent branches with every new update to former PRs? 🤔
from blog.
Thank you @divyanshu013, I've always neglected to use stacked PRs for such reason, but I'll try with giving review fixes in yet another PR. However, this has more upsides than down so definitely worth it.
from blog.
@heytulsiprasad generally the requested changes don't (or shouldn't) require changing UI functionality. Mostly they would be for code style, readability, etc. In that case I would push such changes on the same PR (without rebasing this change onto subsequent stacked PRs). For functional changes you could create a new stacked PR on top of all PRs.
However, say you need functional changes to be reflected on all stacked PRs then it would need a rebase on all subsequent branches unfortunately.
from blog.
Related Issues (13)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blog.