Code Monkey home page Code Monkey logo

Comments (11)

mikek avatar mikek commented on July 27, 2024

Can be possibly added through NewsBlogConfigForm

from aldryn-newsblog.

mikek avatar mikek commented on July 27, 2024

@yakky, @tom I've completely forgot to consider doing this through NewsBlogConfigForm in #77 Can we use the simple setting approach now and look into the per instance configuration in some next iteration?

from aldryn-newsblog.

yakky avatar yakky commented on July 27, 2024

Sure, it makes perfectly sense

from aldryn-newsblog.

intellectronica avatar intellectronica commented on July 27, 2024

Sure, makes sense.

from aldryn-newsblog.

yakky avatar yakky commented on July 27, 2024

@mikek This issue is meant to completely remove the "author" field in the admin, actually
Similar to #65

from aldryn-newsblog.

mikek avatar mikek commented on July 27, 2024

Sorry, I just have noticed this is another issue. Reopening.

from aldryn-newsblog.

mkoistinen avatar mkoistinen commented on July 27, 2024

What's the consensus on this? Can I suggest we make this setting a boolean on the NewsBlogConfig rather than creating new settings entries. This would also allow a Blog instance of this app to use an author field, whilst allowing a News instance to ignore it in the same project.

from aldryn-newsblog.

stefanfoulis avatar stefanfoulis commented on July 27, 2024

+1 on making this a setting of NewsBlogConfig. This kind of thing is one of the main reasons it exists. News entries might not need authors. Blog entries usually do. In any case, author should not be a mandatory field.
And it should be auto-populated with the following priorities:

  1. the current user already has a Person associated: use it
  2. the current user has a first_name and last_name: auto create a Person and associate it.
  3. set author to None.

Templates should handle missing authors gracefully.

If NewsBlogConfig says there should be no authors:

  • hide the author field in admin

@intellectronica @FinalAngel @yakky what do you think?

from aldryn-newsblog.

intellectronica avatar intellectronica commented on July 27, 2024

Yes to all except for auto-creating a Person. IMO that's overreaching.

from aldryn-newsblog.

yakky avatar yakky commented on July 27, 2024

@stefanfoulis +1

from aldryn-newsblog.

FinalAngel avatar FinalAngel commented on July 27, 2024

@stefanfoulis +1

from aldryn-newsblog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.