Code Monkey home page Code Monkey logo

Comments (3)

softprops avatar softprops commented on August 17, 2024

I'll have a quick look into this so see if I can't fix it myself

from reboot.

softprops avatar softprops commented on August 17, 2024

I got rid of the potential for a null pointer with this commit but I found something strange. This request return a 404 in 0.9.3 and a 200 in 0.9.2. I did a quick scan of the changes in this release and I think something broke with the path encoding along the way.

Check this out

In the latest the path gets encoded as

scala> val r = :/("stream.meetup.com") / "2" / "rsvps"
r: com.ning.http.client.RequestBuilder = com.ning.http.client.RequestBuilder@ecdede5

scala> r.build()
res0: com.ning.http.client.Request = http://stream.meetup.com/%32/rsvps GET

But in 0.9.2 the path gets encoded as

scala> val r = :/("stream.meetup.com") / "2" / "rsvps"
r: com.ning.http.client.RequestBuilder = com.ning.http.client.RequestBuilder@48d942c2

scala> r.build()
res0: com.ning.http.client.Request = http://stream.meetup.com/2/rsvps   GET

Should I open a second gh issue and close this one or is this expected behavior for the new path encoding stuff? The fix I just pushed upsteam does a potential bug but just allowed me to find this other issue.

from reboot.

softprops avatar softprops commented on August 17, 2024

killed two birds with two stones in one issue. the issue was that numerics were not in the unreserved list of path segment chars. They are now. Crisis averted.

from reboot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.