Comments (3)
I'll have a quick look into this so see if I can't fix it myself
from reboot.
I got rid of the potential for a null pointer with this commit but I found something strange. This request return a 404 in 0.9.3 and a 200 in 0.9.2. I did a quick scan of the changes in this release and I think something broke with the path encoding along the way.
Check this out
In the latest the path gets encoded as
scala> val r = :/("stream.meetup.com") / "2" / "rsvps"
r: com.ning.http.client.RequestBuilder = com.ning.http.client.RequestBuilder@ecdede5
scala> r.build()
res0: com.ning.http.client.Request = http://stream.meetup.com/%32/rsvps GET
But in 0.9.2 the path gets encoded as
scala> val r = :/("stream.meetup.com") / "2" / "rsvps"
r: com.ning.http.client.RequestBuilder = com.ning.http.client.RequestBuilder@48d942c2
scala> r.build()
res0: com.ning.http.client.Request = http://stream.meetup.com/2/rsvps GET
Should I open a second gh issue and close this one or is this expected behavior for the new path encoding stuff? The fix I just pushed upsteam does a potential bug but just allowed me to find this other issue.
from reboot.
killed two birds with two stones in one issue. the issue was that numerics were not in the unreserved list of path segment chars. They are now. Crisis averted.
from reboot.
Related Issues (20)
- Provide plain-english alternatives to every method in the symbolic DSL
- Bump to AHC to 2.0.33
- Possible domain / group id change HOT 4
- Implement implicit vs explicit verb setting
- Cross-build / abstract against AHC HOT 1
- Investigate different thread allocation semantics under the hood
- Please publish a version for Scala 2.13.0-RC1 HOT 15
- sbt eviction notice HOT 1
- Incorrect UriEncoding of emoji characters HOT 1
- setting request body with << changes method from PUT to POST HOT 6
- Requesting URLs with custom parameters is not possible HOT 6
- Emoji character in domains not recognized correctly (punycode) HOT 1
- Emoji character in domains not recognized correctly (punycode) HOT 8
- Rename primary branch HOT 1
- Add support for Scala 2.13 HOT 1
- Add support for Dotty HOT 5
- Update scala-xml dependency to version 2
- Set up dependency update for this repository
- Snapshots are not deployed to sonatype HOT 1
- Upgrade to AHC 3.0.0 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reboot.