Comments (6)
Nope, it is pretty clear that the hundredths of a second are in the format strD
here, or if you prefer, check the official ECMA spec, it is on page 28.
from go-diskfs.
I am pretty confident that UltraISO is incorrect. If this is 0, it should be 0x48 0x48
, and not 0x00 0x00
. Either way, it definitely is not a null-terminated string.
That having been said, there is no reason why this library couldn't handle those deviant cases, by checking if the hundredths of second is 0x00 and treating either of the fields as 0x48.
Go ahead and open a Pull Request for it.
from go-diskfs.
If you upload an image that fails to be read to somewhere it can be downloaded, we can look at it. I think there are size limits on GitHub issue attachments, but not sure.
from go-diskfs.
I put example ISO-image into zip-archive. There is 3 short text files nested into image for example. When I create this image, I set only creation filestamp and nothing any more.
from go-diskfs.
The creation timestamp on this image appears to be corrupt. The ISO primary volume descriptor date is supposed to be in byte positions 813-829, as follows:
- year: bytes 0-3
- month: bytes 4-5
- date: bytes 6-7
- hour: bytes 8-9
- minute: bytes 10-11
- second: bytes 12-13
- centisecond: bytes 14-15
- offset from UTC: byte 16 (in quarter hours)
All of the above look fine, except for centisecond.
2021 04 20 15 47 16 \x000
They all are ASCII codes for characters, except for the bytes at 14-15, which are: [0,48]
. 0
is a null character, nit a valid number. The ASCII code for the character 0
is 48.
It is possible I misunderstood the spec on that specific part - centiseconds - so checking it again.
from go-diskfs.
I looked in the hex editor image with all timestamp fields set, in all timestamps hundredths of a second is not set, and it's looks like zero-terminated string. Standard does not specify behavior if hundredths of a second is not set (or case when date is set, but time is not set). What is optimal resolution can be for this case I do not know, but I think that broken timestamp can not be a valid reason for image open failure. Those images are produced by popular UltraISO prorgam, so such cases can occurs very often.
from go-diskfs.
Related Issues (20)
- How to close the disk? HOT 1
- gpt can have size larger than minimum size
- Partitions not created HOT 15
- SectorSizeDefault not declared by package diskfs HOT 3
- Is 0o666 a typo? HOT 1
- Can't seem to read fat32 partition HOT 1
- Any plans for a release version? HOT 3
- Implement standard fs.FS interface and friends HOT 3
- Support status for solaris, aix, freebsd, illumos, netbsd, openbsd and plan9 HOT 3
- Incorrect number of partitions reported for the Ubuntu 22.04.02 Server ISO HOT 4
- corrupt GPT with examples/efi_create.go HOT 10
- Create ISO from existing image files with Rock Ridge enabled still errors on filenames longer than 30 characters HOT 11
- Support to remove files HOT 3
- squashfs: read target of symlinks HOT 5
- squashfs: caching of metadata and fragment blocks HOT 8
- Be able to compile to webassembly wasm HOT 3
- need help with finding resourses HOT 1
- Wrong Boot Information Table for ElTorito BIOS boot image larger than 64k HOT 4
- Wrong timestamps for special FAT-32 directory entries HOT 3
- Finalize error with a combination of RockRidge and ElTorito HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-diskfs.