Avoiding regexp in Save() about imaging HOT 5 CLOSED

Yes, you're right. The file extension is checked twice which I don't like too.

I believe I added the regexp to check for supported file extension before calling os.Create(filename). So actually switch default branch never called. Didn't think that regexp matching makes a significant memory usage difference when loading an image.

A pull request would be nice if you have a workaround.

from imaging.

Checking before creation of file is important. Creating a file, only to return an error later is definitely not a clean behavior for Save().

So, we have to either pick a solution which checks the format once but then that may give us a messy code. Or we keep the code clean and check the extension twice. Although, my emphasis was on the use of regexp, which is where the extra memory usage happens. In my opinion, this could be an alternate way of implementing the same behavior: https://github.com/hjr265/imaging/blob/regexp-free-save/helpers.go#L40-L47

If you think that is an acceptable alternate, then I can send you the pull request right away.

P.S When trying to implement Save() which only checks the extension once, I could only think of solutions that become just too complicated. Or too messy.

from imaging.

I think replacing regexp with simple string comparison is a good idea. But can we replace the goto with a boolean variable? I just feel like it's not necessary here. You can send a pull request.

from imaging.

Awesome! I will replace the goto with a bool. Pull request in a few minutes.

from imaging.

Thank you!

from imaging.