Code Monkey home page Code Monkey logo

Comments (4)

madisvain avatar madisvain commented on August 25, 2024 1

@dinoperovic I think is_enabled is actually a much better idea and would solve all our questions much easier.

from django-salesman.

dinoperovic avatar dinoperovic commented on August 25, 2024

Hi @madisvain, would adding something like is_enabled(self, request) method on PaymentMethod class solve your case? That way you could disable payments for a specific request.

This requires adding an optional request param to the pool methods such as get_choices and get_payments and the drawback would be that all URL's for payments are still included (even though they are disabled).

Are there any other advantages to making PaymentMethodPool overridable instead?

from django-salesman.

dinoperovic avatar dinoperovic commented on August 25, 2024

@madisvain I will try to implement this soon then.

from django-salesman.

dinoperovic avatar dinoperovic commented on August 25, 2024

@madisvain added in v1.1.6

from django-salesman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.