When setting the $useTranslationFallback attribute on

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Creating (non-fallback) translations doesn't work if $useTranslationFallback is set about laravel-translatable HOT 1 CLOSED

dimsav commented on May 30, 2024

Creating (non-fallback) translations doesn't work if $useTranslationFallback is set

from laravel-translatable.

Comments (1)

dimsav commented on May 30, 2024

Hi @lan0,

thanks for mentioning the issue. I don't think a third parameter is needed. The problem here is that getTranslation() will take $this->useTranslationFallback if set first, and secondly $withFallback.

We could solve this issue by making $withFallback default to null, and give it higher priority if set. Something like that:

/**
 * Alias for getTranslation()
 */
public function translate($locale = null, $withFallback = null)
{
    return $this->getTranslation($locale, $withFallback);
}

public function getTranslation($locale = null, $withFallback = null)
{
    $locale = $locale ?: App::getLocale();

    if ( ! isset($withFallback))
    {
        $withFallback = isset($this->useTranslationFallback) ? $this->useTranslationFallback : false;
    }

    // ...
}

After this change, the following code will return the appropriate locale:

App::make('config')->set('app.fallback_locale', 'en');
$country = Country::create(['iso' => 'gr']);
$country->useTranslationFallback = true;
$country->translate('en', false)->name = 'Greece';
$country->translate('de', false)->name = 'Griechenland';
dd($country->translate('en')->name); // Will echo Greece