Code Monkey home page Code Monkey logo

Comments (3)

huttarichard avatar huttarichard commented on June 5, 2024

@hieven not sure man, I like both of them, but not really sure if this is a case for feed. Feed was meant to be a class which will iterate until there is not other data to iterate. In this case getRankedItems will return static amount of data which will never have a cursor you can iterate with. locationFeed.get({ ranked: true }) seems to be ok, but only if you merge data from first cursor and ranked data together (and set property ranked on media instance, which lead to changing more code and not get exception where normal data is not available). So I believe neither of these two solutions are perfect.

I think maybe better solution would be to simple define static method Location.getRankedMedia(session, locationId).

from instagram-private-api.

hieven avatar hieven commented on June 5, 2024

yes, you're right. static amount for a feed might me confusing for users

so I will make Location.getRankedMedia(session, locationId) which simply is a copy of LocationMediaFeed.prototype.get

Thanks for your opinion.

from instagram-private-api.

huttarichard avatar huttarichard commented on June 5, 2024

@hieven thank you very much! looking forward to see your commit :)

from instagram-private-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.