Code Monkey home page Code Monkey logo

Comments (8)

taylorotwell avatar taylorotwell commented on July 20, 2024

I am again going to have to fork this project just to get Laravel Forge back online. Please please please fix how you are detecting these properties. If DigitalOcean adds a new one your library breaks EVERY time.

from client.

luceos avatar luceos commented on July 20, 2024

Totally agree with Taylor. A simply change in property now makes the library and any package depending on yours unusable.

http://awesomescreenshot.com/06e3ubyxb9

from client.

yassirh avatar yassirh commented on July 20, 2024

This library isn't meant for production yet since the api is still in beta and changes often. i will update the library to add any missing fields.

from client.

yassirh avatar yassirh commented on July 20, 2024

@taylorotwell the point of the exception we are throwing is that we can determine the changes since they are not always documented in the change log : https://developers.digitalocean.com/changelog/

from client.

luceos avatar luceos commented on July 20, 2024

You should also check my screenshot. Size has been renamed sizeSlug.

from client.

yassirh avatar yassirh commented on July 20, 2024

@luceos that was fixed on babb533 i will make a new release today reflecting all the fixes

from client.

luceos avatar luceos commented on July 20, 2024

Renaming size to sizeSlug property will give you obsolete lines 151-153 (https://github.com/toin0u/DigitalOceanV2/blob/babb533d8ab48265c3cdac4f6e48f36fe9f569d6/src/Entity/Droplet.php#L151). Renaming those lines as well will cause a new exception, so that's no option.

from client.

yassirh avatar yassirh commented on July 20, 2024

@luceos You are absolutely right! those lines are obsolete. there is no point of catching the sizeSlug property because it is handled automatically. i will remove them. thank you!

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.