Comments (8)
@Kotpes That's ok. You can do most of it and leave those details to me in that case.
from react-boilerplate.
@Kotpes would you be willing to do this? All the information should already be scattered around the docs
folder.
from react-boilerplate.
@crisu83 Can do, probably, some of it at least.
Not sure about the reasoning behind certain things, e.g. in index.js
:
import type {RootProps} from './root/components/Root'
const rootProps = {
store: configureStore(),
}
const renderApp = (component: any, props: RootProps) =>
render(
<AppContainer>
{createElement(component, props)}
</AppContainer>,
document.getElementById('root')
)
renderApp(Root, rootProps)
Some other parts too
from react-boilerplate.
@Kotpes We could consider adding some inline documentation in the code, especially in root
folder. That's what they did for the configuration part in CRA.
from react-boilerplate.
@crisu83 IMHO now there are too many inline comments - distracts from reading code
from react-boilerplate.
@Kotpes are you talking about the Webpack configuration? That's out of our hands, because it comes directly from CRA.
from react-boilerplate.
@crisu83 Damn! Ok
from react-boilerplate.
Closing, this project is deprecated. Please use Create React App instead.
from react-boilerplate.
Related Issues (18)
- Make sure distribution build can be built with yarn install --production dependencies
- Add basic Travis build HOT 1
- "Assertation library" typo in README
- Update eslint HOT 3
- Async/await HOT 1
- Feature wish: react-foundation or similar Foundation integration HOT 2
- Which node.js version you use? HOT 2
- Upgrade to React Router v4 HOT 2
- A bug with production builds when using css-modules on Webpacks' css-loader HOT 3
- Upgrade to Webpack 3
- Swap Redux for MobX
- Test coverage is missing HOT 1
- Use Recompose instead of Lodash HOT 1
- How to add sass in the most effective way? HOT 1
- Delete stale branches? HOT 1
- Standard boilerplate won't build HOT 1
- [IE11] Not render anything on dev HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-boilerplate.