Code Monkey home page Code Monkey logo

Comments (4)

ahuseby avatar ahuseby commented on June 12, 2024 1

This would be a good addition indeed.

An important difference between issue_comment and pull_request_review_comment is that GITHUB_REF is the default branch for the former, but refs/pull/PULL_REQUEST_NUMBER/merge for the latter (see docs). This makes the review comment more integrated into the pull request context (e.g. not having to do this).

A GitHub feature request has been raised for making issue_comment in PRs (or a new PR comment event type) use the PR ref, but until then the pull_request_review_comment is the best option.

from digger.

motatoes avatar motatoes commented on June 12, 2024

Interesting, looks like that triggers a pull_request_review_comment event :D . We need to handle that in orchestrator and handle it as a comment event 👍 Adding as good first issue to see if someone wants to grab it

from digger.

motatoes avatar motatoes commented on June 12, 2024

Thanks @ahuseby ! So we will need to that event and handle it on digger side. I think issue number will still remain so that action.yml logic would still work

from digger.

ahuseby avatar ahuseby commented on June 12, 2024

Thanks @ahuseby ! So we will need to that event and handle it on digger side. I think issue number will still remain so that action.yml logic would still work

That's right 😄 I'll try and take a look at contributing a change for this

from digger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.