Code Monkey home page Code Monkey logo

Comments (10)

didlich avatar didlich commented on June 28, 2024

+1

from generator-ionic.

jimthedev avatar jimthedev commented on June 28, 2024

Can you go into some detail on what kind of things in the project you'd like to see happening in prod vs development environments? I like this but the environments are very specific to the environments of the generating user. At best we could have, say, prod and dev to start, then have instructions for adding/modifying environments if someone wants to add another environment (staging). I'm just trying to judge exactly what use case these environment variables should serve vs the environment hook mentioned in Issue #72. I feel like if this is implemented then there'd need to be some cohesion between cordova hooks and the build tool config.

from generator-ionic.

diegonetto avatar diegonetto commented on June 28, 2024

I've given this some thought, and since Ionic uses angular, it might make sense to have an app/scripts/config.js file that gets automatically built by Grunt. This would eliminate the need for the after_prepare hook described in #72 that replaces tokens in files. It would also be a more automated solution.

I am experimenting with grunt-ng-constant for this feature.

from generator-ionic.

diegonetto avatar diegonetto commented on June 28, 2024

@morenoh149 @jimthedev I finally ran into the need for this on my latest Ionic project, so I've gone ahead and added this feature to the generator. See the docs here - https://github.com/diegonetto/generator-ionic#environment-specific-configuration

Thanks, and happy coding :)

from generator-ionic.

chandramuralis avatar chandramuralis commented on June 28, 2024

Hi @diegonetto,
This link https://github.com/diegonetto/generator-ionic#environment-specific-configuration doesn't seems to be active now, could you please point to the latest url?

from generator-ionic.

jimthedev avatar jimthedev commented on June 28, 2024

@chandramuralis:

I think it has been moved here:
https://github.com/diegonetto/generator-ionic/blob/master/docs/FAQ.md#how-do-i-add-constants

from generator-ionic.

chandramuralis avatar chandramuralis commented on June 28, 2024

@jimthedev thanks. If possible please update this URL in the gruntfile.

from generator-ionic.

jimthedev avatar jimthedev commented on June 28, 2024

@chandramuralis Would you be willing to make this change via a pull request? It is pretty easy, you can just follow these steps.

  1. Go to https://github.com/diegonetto/generator-ionic/blob/master/templates/common/Gruntfile.js
  2. Click the little pencil icon at the top of the file to bring you to the propose changes screen.
  3. Change line 32 to the correct url: https://github.com/diegonetto/generator-ionic/blob/master/docs/FAQ.md#how-do-i-add-constants

This will fork the repo and put in a pull request so that Diego can accept it.

Thanks!

from generator-ionic.

chandramuralis avatar chandramuralis commented on June 28, 2024

@jimthedev Done and submitted pull request #155
Thanks for the steps, otherwise I would've asked another question.

from generator-ionic.

jimthedev avatar jimthedev commented on June 28, 2024

@chandramuralis My pleasure. Thanks for being an open source contributor!

from generator-ionic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.