Comments (11)
I also see this optional body in the Swagger docs which we are not tracking at all:
{
"mediation_id": "3fa85f64-5717-4562-b3fc-2c963f66afa6",
"metadata": {},
"recipient_keys": [
"H3C2AVvLMv6gmMNam3uVAjZpfkcJCwDwnZn6z3wXmqPV"
],
"routing_keys": [
"H3C2AVvLMv6gmMNam3uVAjZpfkcJCwDwnZn6z3wXmqPV"
],
"service_endpoint": "http://192.168.56.102:8020"
}
from aries-cloudcontroller-python.
Also can we review accept_connection(). This is a helper function combining receive_invitation and accept_invitation. However in doing so we lose ability to pass arguments into these functions.
Suggest we add arguments from both the this function. Not sure. Perhaps we shouldn't even have this helper method as it might confuse people?
from aries-cloudcontroller-python.
receive_invitation() also seems to use string boolean values instead of actual bool for auto_accept
from aries-cloudcontroller-python.
There also seems to be some funny behavior going on with the create_invitation auto_accept argument. This actually is a bool. But for some reason it only works if False is passed in. If I set this to True I get the following error msg:
TypeError: Invalid variable type: value should be str, int or float, got True of type <class 'bool'>
Seems weird. Also if I set it to "true" it works. Thinking possible its because we define this as auto_accept: bool: None
?
Not sure. Otherwise could even be an ACA-Py bug. Worth exploring
from aries-cloudcontroller-python.
Similarly happens with the receive_invitation auto accept argument hmm.
from aries-cloudcontroller-python.
Ah I think I might know whats going on. See controllers/base.py
the admin_request
function. I think we need to make sure the params is a JSON serialized object.
Not actually confident what this line does but don't think it does that.
params = {k: v for (k, v) in (params or {}).items() if v is not None}
from aries-cloudcontroller-python.
Currently the create_invitation function specifies optional parameters
public
andmulti_use
. Both inputs are specified as String values.This is not in line with the Swagger and while it works if I pass in a string public="true" they should be boolean values.
@kaysiz if you are going through the API anyway be good to pick this up along the way.
@wip-abramson I've just had a look at that. I'm not sure whether there is possibly some confusion. Whilst I agree that in the python function it makes more sense to pass True
or False
the python way, in swagger/JSON it is actually "true" and "false" as booleans see also. But maybe that's what you mean or I'm misunderstanding?
from aries-cloudcontroller-python.
Yeah so I think we pass bools to the python function. Then need to serialize the params to turn True into true.
I think we are missing that serialization step in our code.
from aries-cloudcontroller-python.
ah alright, thanks for clarifying
from aries-cloudcontroller-python.
Also can we review accept_connection(). This is a helper function combining receive_invitation and accept_invitation. However in doing so we lose ability to pass arguments into these functions.
Suggest we add arguments from both the this function. Not sure. Perhaps we shouldn't even have this helper method as it might confuse people?
That is an interesting question. WYT we should do? Happy to implement either, but am pretty impartial with a tendency towards taking away the fct altogether might be good because less is more sometimes. However, i do see how that is convenient to have🤷♂️
from aries-cloudcontroller-python.
I also have a tendency to remove altogether. Lets do that.
Think it's not this libraries job to simplify.
from aries-cloudcontroller-python.
Related Issues (20)
- Wrong validation checks for TAAAcceptance model HOT 1
- Possible wrong validation in V10CredentialExchange HOT 4
- Possible wrong return type CredentialDefinitionGetResult HOT 1
- Validaiton Error for V10CredentialExchangeListResult HOT 1
- V20CredFilterIndy possibly wrong HOT 2
- Wrong validation for V20CredExRecord HOT 1
- Wrong validation fro V20CredExRecordListResult HOT 1
- Record ID not provided error for send_proposal method HOT 2
- Uplink warnings for decorator for Python version >= 3.8 HOT 3
- Codacy conflict for uplink controller HOT 5
- Validation error in type IndyProofReqAttrSpecNonRevoked (via IndyProofReqAttrSpec via IndyProofRequest)
- Boolean query parameters should be transformed
- Throw errors when the response throws and error HOT 2
- Roles in credential exchange HOT 2
- Validator for IndyRequestedCredsRequestedPred
- didexchange implicit invitation using public did does not have auto-accept even though supported in ACA-Py
- if body is optional, initialize it without parameters HOT 1
- Any Docs for How to use the New Controller? HOT 4
- Equivalent to aca-py start HOT 1
- Anything about WebHook handlers? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aries-cloudcontroller-python.