[hellfire] OperateL2Door - Please check bin exactness about devilution HOT 10 CLOSED

Happy to see you join us in the reversing efforts @Chance4us :)

from devilution.

https://discord.gg/MX8VhHu

from devilution.

Thank you @qndel

from devilution.

void OperateL2Door(int pnum, int i, DIABOOL sendflag)
{
	int dpx, dpy;

	dpx = abs(object[i]._ox - plr[pnum]._px);
	dpy = abs(object[i]._oy - plr[pnum]._py);
	if (dpx == 1 && dpy <= 1 && object[i]._otype == OBJ_L2LDOOR)
		OperateL2LDoor(pnum, i, sendflag);
	if (dpx <= 1 && dpy == 1 && object[i]._otype == OBJ_L2RDOOR)
		OperateL2RDoor(pnum, i, sendflag);
}

bin exact in this form

from devilution.

It's known that it's not bin exact for hellfire: #1397

from devilution.

That's why I decompiled it. It looks a little different in the picture above.
Look at the yellow dots. It should be checked whether the changes will lead to bin exactness.

from devilution.

If you like we can help you setup the tools so that you can check and make a pull request that makes it bin exact

from devilution.

Yes. Thank you. That would be helpful. I'll be asking some questions about the tools soon if that's okay.

from devilution.

Definitely. Though it would be easiest via chat, there is even a channel there with a guide for how to get things running for working on Hellfire.

from devilution.

Thank you also for the effort of all of you guys.
Can anyone describe how I can join the chat channel?

from devilution.