Comments (9)
@cooper-joe this is not a breaking change, so there's nothing really preventing us from doing this now. However, since we are migrating this repo to @dhis2/ui
, I think it'd be better to work on it there.
from ui.
Thanks for reporting. @cooper-joe do you have any suggestions with regards to this? Perhaps activating the hover styles on focus
as well? And making sure this gets overridden by the selected
style? IMO an outline wouldn't look very good in a TabBar....
from ui.
Yes, we should definitely activate the hover styles on focus
, good idea. Although I don't think that just the hover style is clear enough for keyboard navigation.
Is it possible to, when the tab has focus, outline the text only?
Here is a rough illustration of what I mean:
from ui.
Great idea! I'll work on this once we get next
released 👍
from ui.
@cooper-joe I've given this a little try and it's definitely possible. Could you let me know:
- padding around the text
- border color/thickness/style
from ui.
Thanks @HendrikThePendric. Let's go for:
border: 1px dotted var(--grey900);
padding: 0px 2px;
(based on an application directly on the text)
from ui.
Hi! Due to a lack of activity on this issue over time it seems to be stale. If still relevant, please provide information that moves it forward: e.g. more information, reason to keep it open, supply a pull request, etc.
Any activity will keep it open, otherwise it will be closed automatically. Thanks! 🤖
from ui.
Still relevant. @HendrikThePendric I just tested the latest ui-core and these styles weren't present. Do you think we can add them now, or is it better to wait until ui
5?
from ui.
https://jira.dhis2.org/browse/LIBS-77
from ui.
Related Issues (20)
- The automated release is failing 🚨 HOT 1
- Library-wide minimum accessibility standard for all components
- FlyoutMenu inside a Popover: a double border is shown HOT 1
- FlyoutMenu with a disabled MenuItem requires onClick HOT 1
- Transfer: onEndReached not triggered if an item is selected HOT 4
- Hovering over a SingleSelectField's label gives a console warning HOT 1
- OrganisationUnitTree: Alphabetical sorting HOT 1
- Content of disabled buttons is not as legible due to decreased opacity HOT 4
- Enabled textfields don't have a white background HOT 2
- Infinite scrolling improvements HOT 1
- Translation error HOT 1
- Scrollbar showing in select at certain zoom levels HOT 2
- Label and field typography adjustments
- Disabled toggle styles only affects text labels HOT 1
- Simplify button styles HOT 1
- 100% cpu usage with certain use of the alertstack/alertbar HOT 3
- Only add icon to the first button in SplitButton HOT 1
- test HOT 1
- Tabs component DX is not consistent with Select/Transfer HOT 2
- The automated release is failing 🚨
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ui.