Code Monkey home page Code Monkey logo

Comments (9)

HendrikThePendric avatar HendrikThePendric commented on June 12, 2024 1

@cooper-joe this is not a breaking change, so there's nothing really preventing us from doing this now. However, since we are migrating this repo to @dhis2/ui, I think it'd be better to work on it there.

from ui.

HendrikThePendric avatar HendrikThePendric commented on June 12, 2024

Thanks for reporting. @cooper-joe do you have any suggestions with regards to this? Perhaps activating the hover styles on focus as well? And making sure this gets overridden by the selected style? IMO an outline wouldn't look very good in a TabBar....

from ui.

cooper-joe avatar cooper-joe commented on June 12, 2024

Yes, we should definitely activate the hover styles on focus , good idea. Although I don't think that just the hover style is clear enough for keyboard navigation.

Is it possible to, when the tab has focus, outline the text only?

Here is a rough illustration of what I mean:
image

from ui.

HendrikThePendric avatar HendrikThePendric commented on June 12, 2024

Great idea! I'll work on this once we get next released 👍

from ui.

HendrikThePendric avatar HendrikThePendric commented on June 12, 2024

@cooper-joe I've given this a little try and it's definitely possible. Could you let me know:

  • padding around the text
  • border color/thickness/style

from ui.

cooper-joe avatar cooper-joe commented on June 12, 2024

Thanks @HendrikThePendric. Let's go for:

border: 1px dotted var(--grey900);
padding: 0px 2px;

(based on an application directly on the text)

from ui.

stale avatar stale commented on June 12, 2024

Hi! Due to a lack of activity on this issue over time it seems to be stale. If still relevant, please provide information that moves it forward: e.g. more information, reason to keep it open, supply a pull request, etc.
Any activity will keep it open, otherwise it will be closed automatically. Thanks! 🤖

from ui.

cooper-joe avatar cooper-joe commented on June 12, 2024

Still relevant. @HendrikThePendric I just tested the latest ui-core and these styles weren't present. Do you think we can add them now, or is it better to wait until ui 5?

from ui.

varl avatar varl commented on June 12, 2024

https://jira.dhis2.org/browse/LIBS-77

from ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.