Comments (5)
This ties into the width
discussion going on in: dhis2/ui-core#456 (comment)
If a Label
can be inline to the left of the input, then what width should the label be? How should it wrap?
What happens when the user is on smaller screen? Does it stack? At what point to we break the layout to stacked? This ties into: dhis2/notes#59
from ui.
This ties into the
width
discussion going on in: #456 (comment)If a
Label
can be inline to the left of the input, then what width should the label be? How should it wrap?What happens when the user is on smaller screen? Does it stack? At what point to we break the layout to stacked? This ties into: dhis2/notes#59
Left-aligned labels do definitely introduce the potential for bad-looking inputs! These points you raise highlight that. To address the points:
- I think we'd define a default width and then the label would wrap after that. Width would be defined as you laid out in dhis2/ui-core#456 (comment)
- Stack on small screens, yes. We haven't tackled this properly yet, but my gut tells me break to stacked when we get to the 'mobile'-ish breakpoint which I think we'd set around <420.
I am not sure about implementing this. I can definitely see the use cases, but I think it could introduce the potential for some bad inputs. If someone made a form with left-aligned inputs and gave them all different label.width
... that would be a difficult to parse form! So this may be a case where we intentionally keep the component locked down.
from ui.
Hi! Due to a lack of activity on this issue over time (7.776*10^9 ms and counting, to be precise) it seems to be stale. If there is no further progress on it, it will be closed automatically.
If this is still relevant, maybe there is something you can do to move it forward? For example provide further information in a comment, or supply a PR? Any activity on this issue will keep it open. Thanks!
from ui.
Still relevant, but no action needed yet. I think this issue should be kept open to track the feature, but it is not immediately needed.
from ui.
Please re-report in JIRA with an actionable issue.
from ui.
Related Issues (20)
- Single- & MultiSelectField: Loading icon not consistent with InputField HOT 6
- Transfer: add a prop for scrolling source to top HOT 1
- FlyoutMenu inside a Popover: a double border is shown HOT 1
- FlyoutMenu with a disabled MenuItem requires onClick HOT 1
- Transfer: onEndReached not triggered if an item is selected HOT 4
- Hovering over a SingleSelectField's label gives a console warning HOT 1
- OrganisationUnitTree: Alphabetical sorting HOT 1
- Content of disabled buttons is not as legible due to decreased opacity HOT 4
- Enabled textfields don't have a white background HOT 2
- Infinite scrolling improvements HOT 1
- Translation error HOT 1
- Scrollbar showing in select at certain zoom levels HOT 2
- Label and field typography adjustments
- Disabled toggle styles only affects text labels HOT 1
- Simplify button styles HOT 1
- 100% cpu usage with certain use of the alertstack/alertbar HOT 3
- Only add icon to the first button in SplitButton HOT 1
- test HOT 1
- Tabs component DX is not consistent with Select/Transfer HOT 2
- The automated release is failing 🚨
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ui.