Comments (5)
Good idea, I think it will be a challenge. See #60 (comment) for info.
I like the usage of a ResizeObserver
in the Popper, to let the Popper adjust itself when required. But we did also try an alternative approach using a renderId
/ renderCount
prop to force an update. This also worked fine, but makes for a much more quirky API and moves the responsibility for updating the position out of the popper and into whichever component is rendering the popper. This which isn't the most logical separation of concerns and will lead to code-bloat in the long term. If we can't work out a way of fixing these failing tests due to the ResizeObserver
we could consider switching to that more quirky API instead (even though that'd be admitting defeat).
I think we should also look into the setup of our cypress environment... I'm not sure what we are doing now, but we were doing everything in electron
, which usually used some older version of chromium. According to the docs we should be able to use Chrome.
from ui.
Agreed. I did create this PR a while back, when testing running our cypress tests in FF and Chrome: dhis2/ui-core#800
from ui.
So about the cypress tests in Chrome (+ maybe FF, etc.), maybe we could split that into a separate issue. To not muddy the scope for the current one.
from ui.
🎉 This issue has been resolved in version 5.0.0-alpha.17 🎉
The release is available on:
- npm package (@alpha dist-tag)
- npm package (@alpha dist-tag)
- npm package (@alpha dist-tag)
- npm package (@alpha dist-tag)
- npm package (@alpha dist-tag)
- npm package (@alpha dist-tag)
- GitHub release
Your semantic-release bot 📦🚀
from ui.
🎉 This issue has been resolved in version 5.0.0 🎉
The release is available on:
- npm package (@latest dist-tag)
- npm package (@latest dist-tag)
- npm package (@latest dist-tag)
- npm package (@latest dist-tag)
- npm package (@latest dist-tag)
- npm package (@latest dist-tag)
- GitHub release
Your semantic-release bot 📦🚀
from ui.
Related Issues (20)
- The automated release is failing 🚨 HOT 1
- Transfer: add a prop for scrolling source to top HOT 1
- FlyoutMenu inside a Popover: a double border is shown HOT 1
- FlyoutMenu with a disabled MenuItem requires onClick HOT 1
- Transfer: onEndReached not triggered if an item is selected HOT 4
- Hovering over a SingleSelectField's label gives a console warning HOT 1
- OrganisationUnitTree: Alphabetical sorting HOT 1
- Content of disabled buttons is not as legible due to decreased opacity HOT 4
- Enabled textfields don't have a white background HOT 2
- Infinite scrolling improvements HOT 1
- Translation error HOT 1
- Scrollbar showing in select at certain zoom levels HOT 2
- Label and field typography adjustments
- Disabled toggle styles only affects text labels HOT 1
- Simplify button styles HOT 1
- 100% cpu usage with certain use of the alertstack/alertbar HOT 3
- Only add icon to the first button in SplitButton HOT 1
- test HOT 1
- Tabs component DX is not consistent with Select/Transfer HOT 2
- The automated release is failing 🚨
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ui.