Code Monkey home page Code Monkey logo

Comments (5)

HendrikThePendric avatar HendrikThePendric commented on June 12, 2024

Good idea, I think it will be a challenge. See #60 (comment) for info.

I like the usage of a ResizeObserver in the Popper, to let the Popper adjust itself when required. But we did also try an alternative approach using a renderId / renderCount prop to force an update. This also worked fine, but makes for a much more quirky API and moves the responsibility for updating the position out of the popper and into whichever component is rendering the popper. This which isn't the most logical separation of concerns and will lead to code-bloat in the long term. If we can't work out a way of fixing these failing tests due to the ResizeObserver we could consider switching to that more quirky API instead (even though that'd be admitting defeat).

I think we should also look into the setup of our cypress environment... I'm not sure what we are doing now, but we were doing everything in electron, which usually used some older version of chromium. According to the docs we should be able to use Chrome.

from ui.

ismay avatar ismay commented on June 12, 2024

Agreed. I did create this PR a while back, when testing running our cypress tests in FF and Chrome: dhis2/ui-core#800

from ui.

ismay avatar ismay commented on June 12, 2024

So about the cypress tests in Chrome (+ maybe FF, etc.), maybe we could split that into a separate issue. To not muddy the scope for the current one.

from ui.

dhis2-bot avatar dhis2-bot commented on June 12, 2024

🎉 This issue has been resolved in version 5.0.0-alpha.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

from ui.

dhis2-bot avatar dhis2-bot commented on June 12, 2024

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.