Issues with context when using different instances of our libs about ui HOT 6 CLOSED

Confirmed that the issue in DV was because it was using multiple versions of ui-core. This has now been resolved to 4.16.0, which fixes the issue. z-index correctly sets to 3001. 🎉

from ui.

Some directions we could take this:

• Just file this as a known limitation and make sure @dhis2/ui-core / @dhis2/ui is always a peer-dependency, so every app just ends up with a single instance of it...
• Don't use context, but implement a layer system that purely relies on DOM traversal.
• Introduce some sort of wrapper component that creates the base Layer context so the context is not created in the Layer module
• Forget about the whole layering system and expose a zIndex prop on every component that "pops up", so that the app can control this...

These are just some pretty random ideas... Nothing is tested and everything is fully hypothetical...

from ui.

FYI: I see we also have a TableContext file. It seems less likely that this is going to cause similar problems, but it does also create the context in the module too.

from ui.

See this PR for an illustration of the problem #16, specifically the http://localhost:5000/?path=/story/component-widget-layer--it-falls-apart story...

from ui.

This is a problem with anything that uses hooks really, and the consumers need to make sure that UI resolves to a single instance inside of node_modules. The best option is probably to use the resolutions property in package.json as we do for React.

from ui.

Update: @amcgee and @martinkrulltott are looking into a way of solving this in the app. If they are successful, we should provide instructions on how to prevent this problem in the docs.

from ui.