Code Monkey home page Code Monkey logo

Comments (2)

Mohammer5 avatar Mohammer5 commented on June 5, 2024 1

By extracting the ui-forms component to ui-core, we will be effectively be introducing that behaviour anyway, so that todo can be removed.

le done

from ui.

HendrikThePendric avatar HendrikThePendric commented on June 5, 2024

I think this is probably a good idea for the reasons @Mohammer5 mentions. There are a few things to keep in mind though:

  • This FileInputWithList component will not be as composable as the other components we have in ui-core. It won't accept any children, and instead render FileListItems based on an array of File instances.
  • Most of our ui-core components are sort of analogue to native elements, but this one work a bit differently (i.e. appending files to a list and being able to remove individual entries) to conform to our design specs.

Just to clarify my stance on this: I am mentioning the points above because these were things that crossed my mind when discussing this with @Mohammer5. I don't really have any objections to introducing FileInputWithList to ui-core, provided we also keep the current File* components. It's probably a wise move.

Finally I'd like to add one correction on the ToDo list:

Make component add files instead of replace when already having files

By extracting the ui-forms component to ui-core, we will be effectively be introducing that behaviour anyway, so that todo can be removed.

from ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.