flattenTree function doesn't persist isBranch property about react-accessible-treeview HOT 11 CLOSED

@mellis481 Both.
We are displaying a file tree ( As this example https://dgreene1.github.io/react-accessible-treeview/docs/examples-DirectoryTree ).
The isBranch is used to display it as a folder in case it is empty ie. empty children,

Data is loaded asynchronously before the component is loaded but is also populated as data is changed ( removed, added, changed or moved )

from react-accessible-treeview.

Closing since this is a duplicate of #86. Once #117 is merged you’ll be able to set that prop on the metadata object.

from react-accessible-treeview.

Released in https://github.com/dgreene1/react-accessible-treeview/releases/tag/v2.6.0

from react-accessible-treeview.

This should be opened again since it doesn't solve the problem.

What I can see #117 preserves the metadata. But isBranch is not part of metadata according to the API Reference.

I'm running 2.8.0 and flattenTree removes isBranch from the JSON object.

from react-accessible-treeview.

@hnnweb would you consider submitting a PR now that I’ve reopened the issue?

from react-accessible-treeview.

The original one from @sandro768 should do it...

from react-accessible-treeview.

@hnnweb I approved it and merged it, but I’m not sure when the team will be able to release it. Hold tight while I get an answer. Check the release notes since I might forget to update you here.

from react-accessible-treeview.

Hey @dgreene1 i see the potential issue in #123. Now tree can display the branch node without any children, please see screenshots below.
The view ('Onion' is set as branch but with children: [] or without children property):

The code:

from react-accessible-treeview.

@kpustakhod That is the purpose.
If you build the native tree ( with id and parent ) it works like this.

flattenTree didn't take isBranch into the object.

Please see the documentation:
https://dgreene1.github.io/react-accessible-treeview/docs/api#data

from react-accessible-treeview.

flattenTree didn't take isBranch into the object because it is used not only for async functionality. I try to highlight that after #123 those users who use flattenTree and don't load data asyncroniously will possibly get a broken tree view if somehow they've set isBranch prop in object that is passed to flattenTree.
Additionally i would expect some tests are added insrc/__tests__/FlattenTree.test.ts and async examples in storybook are also updated.

from react-accessible-treeview.

@hnnweb Are you loading data asynchronously?

from react-accessible-treeview.