Code Monkey home page Code Monkey logo

Comments (8)

sayjeyhi avatar sayjeyhi commented on May 18, 2024

I provided the fix for this issue @dgknca

from tailwindcss-full-bleed.

dgknca avatar dgknca commented on May 18, 2024

Hi @sayjeyhi . Thanks for the issue. But i can't reproduce what you said. Can you create a minimal repo that reproduces the issue you're experiencing? Or you can just give me the css you wrote. I checked this and didn't see any problem:

size-40 bleed-border-t-2 bleed-red-500 md:bleed-none

from tailwindcss-full-bleed.

sayjeyhi avatar sayjeyhi commented on May 18, 2024

@dgknca you need to have a border on the desktop:
size-40 bleed-border-t-2 bleed-red-500 md:bleed-none md:border-gray-200

then in desktop the border top and bottom will be effected

from tailwindcss-full-bleed.

dgknca avatar dgknca commented on May 18, 2024

I tried your code and still can't see any border on desktop. Can you create a project from scratch (with create-next-app etc.) and try again to see if your issue related to the plugin?

from tailwindcss-full-bleed.

sayjeyhi avatar sayjeyhi commented on May 18, 2024

Create an app in next.js 14 and replace page.js/ts with this:


export default function Home() {
  return (
    <div className="max-w-[400px] mx-auto p-9 my-24 border border-amber-700">
      <div className="size-64 flex flex-col items-center border-2 border-amber-700 rounded-2xl bleed-border bleed-red-500 md:bleed-none">
        TEST
      </div>
    </div>
  )
}

Sample app:

reproduce.zip

In desktop the top and bottom borders are dark but I applied amber-700
Screenshot 2024-01-07 at 01 10 50

In Mobile bleed is fine:

Screenshot 2024-01-07 at 01 11 34

from tailwindcss-full-bleed.

dgknca avatar dgknca commented on May 18, 2024

I just reviewed it and see the issue. So you want to have bleeding borders at the top and bottom on mobile only and regular borders on desktop, right? if you do this md:border-2 md:border-amber-700 it will work fine. (it's not dark, there is no top-bottom border on desktop)

In the PR, you added var(--tw-full-bleed-color) to the border colors but here it doesn't matter what the border color is. Bleed color is specified in border-image. If you will have bleed-none on md breakpoint, you shouldn't care about anything from bleed classes from lower breakpoints. We should say "I reset the bleeding on md, so I no longer have to consider anything from it". But if you add var(--tw-full-bleed-color) in bleed borders, you say you want to use this fallback color even if you reset the bleeding. It's not a best-practice. (In your situation this won't work too, because border-top and bottom widths are 0. You will need to make md:border-2 anyway) You should specify border-width and color after resetting the bleed.

from tailwindcss-full-bleed.

sayjeyhi avatar sayjeyhi commented on May 18, 2024

Well, actually in my case it was happening and I couldn't find any other solution and cloned the repo and using the cloned one, anyways thanks for the great work

from tailwindcss-full-bleed.

dgknca avatar dgknca commented on May 18, 2024

ok. I'm always here for help. Closing this now.

from tailwindcss-full-bleed.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.