Code Monkey home page Code Monkey logo

Comments (5)

sirlee avatar sirlee commented on July 20, 2024

Update:

small change that will only trigger the aspect patch when the height change is triggered:


	if ( ( !pinhack.specifichack.pinballdreams.enabled || pinhack.specifichack.pinballdreams.trigger ) && 
            ( height>=pinhack.triggerheight.min && height<=pinhack.triggerheight.max ) &&
            ( pinhack.triggerwidth.min<=width && width<=pinhack.triggerwidth.max ) ) {
              	printf("triggered -> ");
              	pinhack.trigger = true;
           	printf("original geometry: %dx%d. expanding to geometry: %dx%d.\n",width,height,
			pinhack.expand.width ? pinhack.expand.width : width,
			pinhack.expand.height ? pinhack.expand.height : height);
		// If width or height not set, do not expand!
		if ( pinhack.expand.height ) height = pinhack.expand.height;
		if ( pinhack.expand.width ) width = pinhack.expand.width;
              	if ( pinhack.specifichack.pinballdreams.trigger ) pinhack.specifichack.pinballdreams.trigger=false; // On next resolution change, return to normal
       aspect_ratio = pinhack.aspectratio;
	   } else {
              	pinhack.trigger = false;
              	printf("trigger values evalueted but not triggered! Current resolution: %dx%d\n",width,height);
       };
		//aspect_ratio = ((float)width / (float)height) * ( 25.0 / 7);
		//aspect_ratio = pinhack.aspectratio;

from dosbox-pinhack.

DeXteRrBDN avatar DeXteRrBDN commented on July 20, 2024

Thanks sirlee!! :D We can try adding those changes in the repository. If you have any repo modifications, please feel free to create a PR or I'll try to create the changes and add them to master branch.

Thanks again 👏

from dosbox-pinhack.

sirlee avatar sirlee commented on July 20, 2024

I have to say I am no full-blown programmer. I know some C++ from Arduino and have some experience with Visual Studio, but I am a bit lost when it comes to GITHub and its terminology.
I do not even know what you mean with PR. 

Therefore, may I ask you to try to put it into the master branch?

Thanks you very much for putting time/effort into this solution!

from dosbox-pinhack.

Torinde avatar Torinde commented on July 20, 2024

@Kappa971, you may be interested in this?

from dosbox-pinhack.

Kappa971 avatar Kappa971 commented on July 20, 2024

@Kappa971, you may be interested in this?

I'm interested in anything that might make those games display properly, but I'm not a developer.
You need to ask the DOSBox Staging developers if they are interested in this patch.

from dosbox-pinhack.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.