Comments (2)
derek-watson
commented on June 30, 2024
@Emerson I'm happy to submit a PR for this one if you want to tell me which way to go with it
from devour-client.
Emerson
commented on June 30, 2024
I think we went with the singleton pattern (an admittedly janky version of it) in the hopes that it would be easy to define models and then pull in jsonApi throughout the project and know that we always had the same instance.
In hindsight, I think you're absolutely correct and that if we want to have a singleton pattern, we should handle that in the host application code rather than this library. Would be happy to see this updated 👍
from devour-client.
Related Issues (20)
- Including recursive relationships result in null object
- The middleware does not exist HOT 8
- "Included" related resources are wiped if server does not support compound documents
- Is this project dead? HOT 2
- Improve Documentation HOT 1
- How to handle refresh Token HOT 2
- TypeScript type definitions HOT 4
- Way to consume relationships on the fly ? HOT 2
- `get` does not add model to req object HOT 2
- Congratulations and questions HOT 2
- Support for relationship metadata deserialization
- The example under Quick Start in the README confusingly uses "post"
- Please consider using release notes
- Add option to specify log level
- Update axios package to > 0.21.1 to solve security vulnerability HOT 14
- move CI to either travis-ci.com or github actions HOT 2
- Cross check JSON:API 1.1 compatibility
- Move devour to its own GitHub Org HOT 13
- API resource definition for model "foo" not found.
- Missing Relationship Function: DELETE HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devour-client.