Steps to include core module unclear about jump-the-queue HOT 4 CLOSED

Hi trivesc,

I am currently in another attempt to learn more about devn4ng and Angular in general. I have only very little experience outside the java-based server domain, so everything (node.js / npm, angular CLI, typescript, ... and even HTML and JavaScript) is completely new to me.

Therefore, I am extremely easily confused by ambiguities in instruction texts and examples.

Please be tolerant if my issues are to nitpicky.

from jump-the-queue.

Hello Jan-PeterRichterCG,
It is better that your issues are nitpicky, that way, the guide can be improved to the point where there is no issues and everything is clear.

Thanks for the feedback

from jump-the-queue.

Hello Jan-PeterRichterCG,

When the guide talks about importing the CoreModule, it means that in every component (that has a module) where you use either Angular Material or Covalent Teradata has to have the CoreModule imported on their module. If the component has no module, it will use the app module.

Concerning the import { HttpClientModule } from '@angular/common/http';: it is not needed since, we already import the HttpClientModule in the core. You can remove the import and the declaration inside Imports: [

Finally, import 'hammerjs'; , this javascript library needs to be imported when gesture is being used. Yarn does not import it automatically, you need to add it manually.

I am sorry for the confusion and i will be fixing everything you have mentioned here and in the other issues as soon as possible.

Thanks for the feeback

from jump-the-queue.

Hello @Jan-PeterRichterCG ,
The CoreModule explanation has been changed to be more understandable. After adding the covalent and material libraries with yarn, the user sees this text:

Angular Material and Covalent need the following modules to work: CdkTableModule, BrowserAnimationsModule and every Covalent and Material Module used in the application. These modules come from @angular/material, @angular/cdk/table, @angular/platform-browser/animations and @covalent/core. In futur steps a CoreModule will be created, this module will contain the imports of these libraries, this will avoid code repetition.

Also, after creating the CoreModule, a note was added and the text after it clarified:
Note:

This CoreModule has almost every module of the different components for Angular Material and Covalent Teradata if you decide to use a component that is not included here, you need to add the corresponding module of the component here.

Text:

Remember that we need to import this CoreModule module into the app.module and inside every module of the different components that use Angular Material and Covalent Teradata. If a component does not have a module, it will be imported in the AppModule and hence, have the CoreModule. Our app.module.ts should have the following content:

The extra import from HttpClientModule has been removed.

And finally, hammer-js has been added in an earlier step when adding the styles to avoid confusion.

In the same file than previous step, the hammer library is going to be added. In order to do so, we add inside both "scripts" arrays (inside build and test) the minimified script:

i am gonna close this issue since it has been solved,

Thanks for the feedback and regards,
trivesc

from jump-the-queue.