Comments (8)
Since we want to align with Foundation as close as possible, may I suggest using queryParameters
and components
? @MP0w
from kakapo.
Fine for me
from kakapo.
related to #21
from kakapo.
I'll prefer instead something like this when declaring a handler like router.get('/users/:id')
and performing a request like users/12?page=1&limit=10
with empty headers and body
{
params: {id: "12"},
query: {page: "1", limit: "10"},
headers: {},
body: {}
}
Also, I don't like the HTTP
prefix for any of the properties
from kakapo.
HTTP prefix is to align with the Foundation counterpart.
Your code is the same except the naming right?
Not sure if params is right because usually what you now called query is called params (that's why I was confused)
from kakapo.
Since /id/ is an URL component (NSURL
call it that way) I was suggesting components, @joanromano ?
from kakapo.
Yes, my suggestion is all about naming, what i call query is usually called query or queryParams. I don't like components
neither btw.
from kakapo.
I agree with @zzarcon in terms of naming, since Node.js names it in exactly this way
from kakapo.
Related Issues (20)
- Update test dependencies and example dependencies in podfiles
- Add Changelog.md
- Extract serialization in it's own pod HOT 4
- Use travisCI caching HOT 1
- Remove sleep workaround from travis.yml once issue is fixed
- Fix CI random failures
- Update APIs to follow swift 3 naming guidelines HOT 11
- Included relationships of relationships in JSONAPI serialization
- Swift 2.2 support in 1.x release branch HOT 11
- Release PATCH support and backport it HOT 11
- Test some assertions with Quick
- Des-opinionate Api
- Kakapo + Vapor
- Provide way to perform the original requests
- Provide a "Request.continue()" that performs the original request
- Refactor Kakapo to not be JSON centric
- camelCase transformer is broken when there are multiple uppercase chars
- Swift 4 support HOT 2
- Issue when using SwiftLint, carthage failed to build scheme HOT 5
- Swift 5 support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kakapo.