Support for MSSQL Databases about abap-code-search-tools HOT 2 CLOSED

Hi @g-back,

it is certainly possible to also support MSSQL databases. As I only have access to ABAP Systems with HANA and Oracle DBMS connected, I did not want to implement and just blindly push it 😅.

The code that needs to be extended is not extensive:

1. enable dbms support check in the following method
   

   abap-code-search-tools/src/zcl_adcoset_db_support_util.clas.abap

   Lines 16 to 18 in 21b580b

   	METHOD is_db_supported.
   	result = xsdbool( sy-dbsys = 'ORACLE' OR sy-dbsys = 'HDB' ).
   	ENDMETHOD.

2. create custom package reader implementation for MSSQL
   Here is the local class definition for HANA:
   

   abap-code-search-tools/src/zcl_adcoset_search_scope.clas.locals_def.abap

   Lines 207 to 220 in 21b580b

   	CLASS lcl_hdb_scope_obj_reader DEFINITION
   	INHERITING FROM lcl_adbc_scope_obj_reader_base.
   	PUBLIC SECTION.
   	METHODS constructor
   	IMPORTING
   	search_ranges TYPE zif_adcoset_ty_global=>ty_search_scope_ranges
   	current_offset TYPE i.
   	PROTECTED SECTION.
   	METHODS combine_clauses REDEFINITION.
   	METHODS build_offset_clause REDEFINITION.
   	METHODS build_limit_clause REDEFINITION.
   	ENDCLASS.

   
   and the corresponding implementation:
   

   abap-code-search-tools/src/zcl_adcoset_search_scope.clas.locals_imp.abap

   Lines 36 to 54 in 21b580b

   	CLASS lcl_hdb_scope_obj_reader IMPLEMENTATION.
   	METHOD constructor.
   	super->constructor( current_offset = current_offset
   	search_ranges = search_ranges ).
   	ENDMETHOD.
   	METHOD combine_clauses.
   	" HANA expects the LIMIT clause before the offset clause
   	result = select_clause && from_clause && where_clause && order_by_clause && limit_clause && offset_clause.
   	ENDMETHOD.
   	METHOD build_limit_clause.
   	limit_clause = |LIMIT { max_rows } |.
   	ENDMETHOD.
   	METHOD build_offset_clause.
   	offset_clause = |OFFSET { current_offset }|.
   	ENDMETHOD.
   	ENDCLASS.

3. return instance of the MSSQL implementation in the factory method for a package reader
   

   abap-code-search-tools/src/zcl_adcoset_search_scope.clas.locals_imp.abap

   Lines 6 to 15 in 21b580b

   	METHOD create_package_reader.
   	" see domain DBSYS_TYPE_SELECTOR for possible values
   	CASE sy-dbsys.
   	WHEN 'ORACLE'.
   	result = NEW lcl_oracle_scope_obj_reader( search_ranges = search_ranges
   	current_offset = current_offset ).
   	WHEN 'HDB'.
   	result = NEW lcl_hdb_scope_obj_reader( search_ranges = search_ranges
   	current_offset = current_offset ).
   	ENDCASE.

I think that the implementation effort for MSSQL should be similar to Oracle and HANA. You have to check the native clauses for LIMIT and OFFSET in MSSQL and then adjust the implementation for MSSQL accordingly.

Regards,
Ludwig

from abap-code-search-tools.

Closed with #16

from abap-code-search-tools.