Code Monkey home page Code Monkey logo

Comments (7)

mphello avatar mphello commented on September 26, 2024 1

Hi Carmen

Thanks so much for your feedback!

I did not know about "Opening an issue in Github". Thanks for sharing. Its great to know this.

Probably as my wife, Silma & I study and work together it affects to our personal projects,but don't worry. We will be more careful about this point. Thanks for mentioning!

I read all the points you asked me and I tried to include as much as I could in my new html file. I think now in the new file the semantic part has improved. The file has been updated. I would be glad if you could check it out.
Thanks again.

My another homework in html" build a survery form" as well has been updated. Here is the link if you would like to see.
https://github.com/armanpartovi/build-a-survey-form

Thanks for the encouragement! happy New Year!

from tribute-page.

carmen-tm avatar carmen-tm commented on September 26, 2024

Hi Arman!
So good to know about you, thanks for letting me know! I'm gonna have a look right to your Survey Form exercise and let u know in another issue about that one :)

from tribute-page.

carmen-tm avatar carmen-tm commented on September 26, 2024

Hi again, Arman!
First of all, I wish you a Happy New Year :)

I was reviewing all your last improvements, and your exercise looks way much better, well done :):)
I have clicked on all the task list items you have done from our first comment 👆🏻 on this issue ✔. BTW, You can do it yourself next time, this issue and all the task lists things, notes, etc, are for you :)

Your exercise is almost perfect, but I would review a bit the following:

  • You section tag wrapping all the content about Dr. Borlaug life is missing an id attribute of tribute-info (Point 6). Also I think is better if it ends right after the ul, not including the final quote and link (I just think those two things work better as a footer for the website, separate from Borlaung's life).
  • Review again your general structure: Instead of having a main tag wrapping everything inside your body, is a better practice to have a proper header (for your h1 and your first p). Some documentation here. Then you could start your main tag, with all the main information of your website, and in third place, a proper footer tag (in this case, you could place there your quote and your last paragraph with the Wikipedia link). (Some documentation here). So the general structure of your body could be like this:
[...]
<body>
    <header> [...Your h1 and first p...] </header>
    <main> [...Your figure and section...] </main>
    <footer> [...Your quote and final link...] </footer>
</body>

What you have done is OK, but semantically is better to have a clear opening of your page (header), content (main) and closing part (footer).

  • Review your link: according to the exercise, you should add an attribute id with the value tribute-link to your link a, and also give your element an attribute of target and set it to _blank in order for your link to open in a new tab. (Point 7)
  • I have found a new improvement hehe! Review your quote. There is a proper tag for that, have a look to this documentation :)

And that's all! When you are done, you can try to do a final thing 🚀
This is not mandatory, but I think it would so cool if you try to publish your exercise on Github Pages! Here is some documentation about how to create a Github page from an existing repository. Let us know if you have any trouble with it. Once you have the link to your website, you could add that link in your repository details on Github as well as the Description and some Tags about the languages you are using (for example: HTML & CSS).

Happy coding!! 😊

from tribute-page.

mphello avatar mphello commented on September 26, 2024

Hi Carmen

Thanks for your wish.
My wife Silma & I, wish you the best as well in this year.
I appreciate your another feedback for this exercise.
I studied and tried to update changes based on your recommendations.

BTW, I am glad to see that I had improvements. thanks for letting me know.
In case if you need the link to the repo to check the last commits: https://github.com/armanpartovi/Tribute

Regards
Arman Partovifar

from tribute-page.

carmen-tm avatar carmen-tm commented on September 26, 2024

Hi, Arman!
Nice to see your work again, looking that great! :)

My last tiny comment is insist again in the structure of your body. In my opinion it's better if you have a header, a main and a footer at the same label (introduction of the page, main part and final one), so like this:

[...]
<body>
    <header> [...] </header>
    <main> [...] </main>
    <footer> [...] </footer>
</body>

Meaning that your header (from line 9 to 12) should move one line up, so the main tag starts just right after, at the same level :)

Everything else is just...
210057846-636578f2-3c02-4f21-91d8-1ec7fc0a2363

Well done!!
I can't wait to see your next improvements with CSS!!! :D

from tribute-page.

mphello avatar mphello commented on September 26, 2024

Hi Carmen
Thanks again for your another analysis about my codes
I changed the order in codes. Now the structure is in the same order you suggested.

we will upload the new changes in css file as an earliest convenience.

Regards
Arman Partovifar

from tribute-page.

mphello avatar mphello commented on September 26, 2024

Hi Carmen
For this exercise the css file is now available.
I want to let you know in case if you would like to check the css file.

Thanks a lot for your feedbacks
It is pretty helpful for my learning.

Regards
Arman Partovifar

from tribute-page.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.