Code Monkey home page Code Monkey logo

Comments (3)

BraisGabin avatar BraisGabin commented on June 20, 2024

At this point, I'm unsure if this detection is valid, because there would be no function that could be extracted to simplify the code.

A function that receives Any. You only care about the toString of those classes.

Anyway, should this rule check strings with variables inside it? I'm not sure.

from detekt.

TWiStErRob avatar TWiStErRob commented on June 20, 2024

🤦🏻‍♂️ that makes so much sense. So this is a viable option:

fun cycle(start: Any, end: Any): String =
    "cycle ${start}-${end}"

I guess your observation will hold true for any expression inside an interpolated string. So extracting a function with String or Any params is a viable way to fix the duplication.

Could this be just a doc update with a hint then? (TBH, I haven't read the docs of this rule yet, might be already there...)

from detekt.

BraisGabin avatar BraisGabin commented on June 20, 2024

Could this be just a doc update with a hint then?

No sure about what could we write there for this case but sure, any improvement on the docs is more than welcome.

from detekt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.