Comments (12)
And in the meantime it even dropped the dot from py.test
to pytest
. Okay, let me see what we can do. :-)
from destream.
It's been years for me haha 😅
Looking at the function name I guess the 2 tests are identical except for how they pass the file argument to the destream class. Probably at some point one was using a filename instead of a file object. It has to work for both (if that still exists in the API).
But don't take my word for it, try to use git blame on the file and see if they ever were different.
from destream.
Why convert to pytest at all?
from destream.
The syntax with assert
instead of self.assert*
is nicer and more intuitive, the fixtures and parametrization makes the code more readable.
And it looks like touching the whole test codebase could show up some issues like this one :-)
from destream.
I do prefer py.test too! I'm not sure it even existed when this project started.
Overall it's a nice improvement as it is easier to get in the code.
from destream.
But first, #22 needs to be reviewed/approved/merged.
from destream.
Fair enough!
from destream.
Why didn't this get closed with #27?
from destream.
It's because you need to write "Closes #21 " or "Fixes #21" in the commit message
from destream.
Does it have to be a commit message? I remember closing issues with PR messages like this one from our PR that I expected to close this issue:
#27 (comment)
from destream.
Pretty sure (80%) it has to be in the commit message or the title of the commit (which is actually part of the message).
Some words also don't close the linked issue. For instance: "Related #21" will link but not close when the PR gets merged.
from destream.
Found it: in the PR number 19 I wrote Closes
and the number 17 into the PR message. It even highlighted the word Closes
. So maybe this has to be in the initial message (description) of a PR and not in a comment. 🤷
from destream.
Related Issues (13)
- Python 3 Support HOT 9
- zstd has mime type application/zstd instead of application/x-zstd HOT 1
- Looking for maintainers HOT 9
- Drop support for Python versions that are not supported anymore
- Add an .editorconfig HOT 11
- Another project to maintain HOT 17
- Adopting a Code of Conduct HOT 4
- Codecov not working anymore HOT 1
- Implements integration tests for this repository HOT 1
- Released 4.1.0 has a print('guessing') in guesser.Guesser.guess() HOT 2
- Suggestions to improve this repository
- Support zstd HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from destream.