Code Monkey home page Code Monkey logo

Comments (17)

desh2608 avatar desh2608 commented on August 23, 2024

Can you show me what command you ran?

from dover-lap.

desh2608 avatar desh2608 commented on August 23, 2024

Also, you should read this section: https://github.com/desh2608/dover-lap#combining-2-systems-with-dover-lap

from dover-lap.

kfmn avatar kfmn commented on August 23, 2024

Thank you for the answer.
I have not indeed read carefully the section about combining 2 systems. But I still don't understand why the order of input rttms may matter.
The commands I ran were:
dover-lap rttm_out1 rttm_in1 rttm_in2
and
dover-lap rttm_out2 rttm_in2 rttm_in1
And after running them I observed that rttm_out1 differs from rttm_out2 significantly.

In my experiments DER of rttm_in2 is lower than that of rttm_in1 by about 2%.
DER of rttm_out1 is similar to that of rttm_in1 (only a bit better but significantly worse than that of rttm_in2) while
DER of rttm_out2 is even better then that of rttm_in2 by about 1%.

from dover-lap.

desh2608 avatar desh2608 commented on August 23, 2024

Yes that is expected. We fall back to Hungarian mapping for the case of 2 RTTMs, which depends on the order of the provided inputs. You can think of it as the following situation: suppose you have 2 RTTMs (X and Y). DER computation between X and Y is not commutative, i.e., DER(X,Y) != DER(Y,X).

from dover-lap.

kfmn avatar kfmn commented on August 23, 2024

OK, I got it.
Answer please if the result is independent of the order for number of RTTMS >2 ? For each --label-mapping or just for greedy ?

from dover-lap.

desh2608 avatar desh2608 commented on August 23, 2024

In the latest dover-lap, we sort all RTTMs by default by average DER to other RTTMs, so for N>2, it should be independent of the order. Let me know if you find otherwise.

from dover-lap.

kfmn avatar kfmn commented on August 23, 2024

Thank you very much for clear explainations!

from dover-lap.

kfmn avatar kfmn commented on August 23, 2024

I have just checked doverlap from 3 input rttms and found the result doesn't depend of order of inputs for greedy mapping. But still depends for hungarian mapping. 6 different permutations lead to 6 different output RTTMs. Maybe sorting is applied just for greedy and order is preserved for hungarian?

from dover-lap.

desh2608 avatar desh2608 commented on August 23, 2024

Which version of dover-lap are you using?

from dover-lap.

kfmn avatar kfmn commented on August 23, 2024

I installed it several months ago. How can I get a version number?

from dover-lap.

kfmn avatar kfmn commented on August 23, 2024

I've found it. The version is 1.2.0. Will check latest soon

from dover-lap.

kfmn avatar kfmn commented on August 23, 2024

I have installed version 1.3.0 (BTW, I had to build it from sources and install since pip cannot find version upper than 1.2.0)
But I still obtain different results with different permutation of 3 input RTTMs and hungarian mapping
Although the difference seems to become less significant (the range of DER/JER fluctuations for 6 permutations is about 0.2% now, it was larger before)

from dover-lap.

desh2608 avatar desh2608 commented on August 23, 2024

If you can provide a minimum reproducible example, I will take a look later and try to fix.

from dover-lap.

desh2608 avatar desh2608 commented on August 23, 2024

In the meantime, I have created a release for v1.3: https://pypi.org/project/dover-lap/1.3.0/

from dover-lap.

kfmn avatar kfmn commented on August 23, 2024

doverlap.zip
Uploaded a small reproducible example. There are 3 files in zip, which I passed to dover-lap in different order (with --label-mapping=hungarian).
Hope you will look at them soon.

from dover-lap.

desh2608 avatar desh2608 commented on August 23, 2024

@kfmn can you please check if the above PR solves your problem?

from dover-lap.

desh2608 avatar desh2608 commented on August 23, 2024

The new version, which fixes this ordering issue, is available on PyPi: https://pypi.org/project/dover-lap/1.3.1/

from dover-lap.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.