Code Monkey home page Code Monkey logo

Comments (4)

somewhatabstract avatar somewhatabstract commented on July 27, 2024

The issue here is that if you use the commit-message.prefix value in the dependabot.yml it instantly becomes unparseable by this action, because this action parses the commit message as if it were never altered.

I was totally wrong. The issue is that the metadata isn't in the dependabot commit for it to be parsed back out.

Here is what a "good" commit looks like:

somewhatabstract/checksync@52e94cf

Bumps [rollup](https://github.com/rollup/rollup) from 2.57.0 to 2.58.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/[email protected])

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Note the updated-dependencies part. If that is absent, then this action cannot load the required metadata. My guess is that dependabot must've created the PRs in question BEFORE this metadata was getting added. I'll see if I can persuade my PRs to update with the metadata and get back to this issue.

from fetch-metadata.

somewhatabstract avatar somewhatabstract commented on July 27, 2024

I think this is a bug with dependabot. It seems that the inclusion of a prefix to the commit message is causing it to omit the metadata when creating the commit. :( It's because:

  1. The commits were made by dependabot BEFORE it was adding metadata
  2. @dependabot recreate doesn't actually recreate fully. It reuses the same commits and just rebases them - so it never updates them to add the metadata.

As far as I can tell, there's no easy way to convince it to do the right thing for these old PRs.

from fetch-metadata.

mwaddell avatar mwaddell commented on July 27, 2024

I agree with @somewhatabstract - this is caused by dependabot/dependabot-core#4652 and cannot be fixed in fetch-metadata

from fetch-metadata.

brrygrdn avatar brrygrdn commented on July 27, 2024

@Dreamsorcerer Unfortunately this isn't something we can fix in this project, @mwaddell is correct that we have a downstream issue in core to look at how we handle refreshing commit messages.

from fetch-metadata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.