Docs: Update Example to minimize Approval-notification-spam about fetch-metadata HOT 10 CLOSED

Thanks @mwaddell! That looks great. I’ll try that out.

from fetch-metadata.

I can confirm that #188 fixed this issue for us! -- It took a moment to get new Dependabot PRs to verify everything was working!

Obviously we'd still prefer a technique that doesn't require checking out the repo twice, but this is a good workaround for now.

Thanks!

from fetch-metadata.

Warning Turns out, that that CLI command I proposed above doesn’t reliably work. So I’m still looking for a less-noisy solution to this problem if anybody has any advice?

from fetch-metadata.

@fbartho How about something like:

if [ $(gh pr status --json reviewDecision -q .currentBranch.reviewDecision) == "REVIEW_REQUIRED" ]; then 
  gh pr review --approve "$PR_URL"
else
  echo "PR already approved, skipping additional approvals to minimize emails/notification noise."
fi

from fetch-metadata.

@fbartho - let me know if that worked, if so, I'll update the example in our documentation.

from fetch-metadata.

@mwaddell Looks like it's working! Thanks!

from fetch-metadata.

@mwaddell Actually, I spoke too soon. Looks like a bash error?

from fetch-metadata.

I looked into it a bit more, and it looks like this approach won't work until they fix cli/cli#575

👎

from fetch-metadata.

Bummer! Could I ensure our upstream is set for the repo or otherwise configure it for the purposes of this API call?

from fetch-metadata.

Bummer! Could I ensure our upstream is set for the repo or otherwise configure it for the purposes of this API call?

I think I figured out a workaround - see if #188 works for you. It looks a little silly to checkout the repo and then check it out again, but that's the only way to force the upstream to be set properly.

from fetch-metadata.