Code Monkey home page Code Monkey logo

Comments (9)

hsanson avatar hsanson commented on June 12, 2024

This PR #4661 caused the issue. Specifically this line: https://github.com/dense-analysis/ale/blob/master/ale_linters/tex/chktex.vim#L13

Removing that line seems to fix the issue.

from ale.

wcazzola avatar wcazzola commented on June 12, 2024

Thank you for digging the issue. Can you fix it in? So that it will propagate with the next update?

from ale.

wcazzola avatar wcazzola commented on June 12, 2024

Today I updated my plugins and it seems the problem is still there. Since the problem has been investigated and a solution found can be merged to the master? Or can be PR 4661 definitively reverted? Thank you.

from ale.

Jorengarenar avatar Jorengarenar commented on June 12, 2024

I'm not even sure how I let that typo get there, but the fix is to replace -s with -S in line 13

from ale.

wcazzola avatar wcazzola commented on June 12, 2024

thank you

from ale.

hsanson avatar hsanson commented on June 12, 2024

@Jorengarenar I believe we are not using the same chktex tool since there is no -S option supported on my chktex. This PR cases no output from chktex:

(executable check - success) chktex
(finished - exit code 1) ['/bin/bash', '-c', '''chktex'' -v0 -p stdin -q -S TabSize=1 -I < ''/tmp/nvim.ryujin/99CfNd/2/test.tex''']

<<<NO OUTPUT RETURNED>>>

Using small -s uses TabSize=1 as splitchar that is correct according to documentation of chktex but causes ALE to break:

(executable check - success) chktex
(finished - exit code 2) ['/bin/bash', '-c', '''chktex'' -v0 -p stdin -q -s TabSize=1 -I < ''/tmp/nvim.ryujin/6X7MzX/2/test.tex''']

<<<OUTPUT STARTS>>>
stdinTabSize=13TabSize=116TabSize=137TabSize=1You should avoid spaces after parenthesis.
stdinTabSize=13TabSize=115TabSize=115TabSize=1No match found for `('.
stdinTabSize=14TabSize=11TabSize=117TabSize=1Number of `(' doesn't match the number of `)'!
<<<OUTPUT ENDS>>>

Chktex help:

ChkTeX v1.7.6 - Copyright 1995-96 Jens T. Berger Thielemann.
Compiled with PCRE regex support.        

 -s  --splitchar : String used to split fields when doing -v0

I will move forward merging #4725 to remove this -s/-S option altogether.

from ale.

Jorengarenar avatar Jorengarenar commented on June 12, 2024

@hsanson
Indeed, version 1.7.6 (2016-09-09) doesn't have -S option, which was added in version 1.7.7 (2022-10-17).
I'll add a check to test -S option availability.

from ale.

wcazzola avatar wcazzola commented on June 12, 2024

my chktex v1.7.8 has both switches with really different meanings:

  • -S --set : Read it's argument as if from chktexrc.
    e.g., -S TabSize=8 will override the TabSize.
  • -s --splitchar : String used to split fields when doing -v0

I don't know which should be the expected behavior but to avoid any mispelling/misinterpretations I would suggest to use the long version of the switch.

from ale.

hsanson avatar hsanson commented on June 12, 2024

I merged #4725 to fix the issue affecting users, including me. We can add the -S flag as long as it is optional via configuration or auto-detection of chktex version.

For those that need this flag they can use the g:ale_tex_chktex_options or chktexrc configuration to add it. Also note that according to the manual TabSize is by default 8 so not sure why this was needed on first place and that the -S flag does not seem documented:

from ale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.